chore(ci): don't run benchmarks on forks#1755
Open
miketheman wants to merge 1 commit intozizmorcore:mainfrom
Open
chore(ci): don't run benchmarks on forks#1755miketheman wants to merge 1 commit intozizmorcore:mainfrom
miketheman wants to merge 1 commit intozizmorcore:mainfrom
Conversation
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Member
|
Maybe I'm missing something, but doesn't the current check already work? I see the benchmarks getting skipped on your PR here: #1756 |
Contributor
Author
|
They get skipped if it's a PR and doesn't have the label, but a push to my forks main branch, like synchronizing from upstream triggers them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checks
Please check these boxes:
Mandatory: This PR corresponds to an issue (if not, please create
one first).
Having read the AI policy, I hereby disclose the use of an LLM or other
AI coding assistant in the creation of this PR. PRs will not be rejected
for using AI tools, but will be rejected for undisclosed use or
use that violates the policy.
If a checkbox is not applicable, you can leave it unchecked.
Summary
Prevents failures from forks trying to unsuccessfully upload benchmarks to CodSpeed