Skip to content

feat: add avg serial latency output#734

Open
ztorchan wants to merge 1 commit intozilliztech:mainfrom
ztorchan:feat-add_avg_latency_output
Open

feat: add avg serial latency output#734
ztorchan wants to merge 1 commit intozilliztech:mainfrom
ztorchan:feat-add_avg_latency_output

Conversation

@ztorchan
Copy link
Copy Markdown

@ztorchan ztorchan commented Mar 6, 2026 •
edited
Loading

close #735

@sre-ci-robot
Copy link
Copy Markdown

sre-ci-robot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ztorchan
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ztorchan
Copy link
Copy Markdown
Author

ztorchan commented Mar 6, 2026

/assign @XuanYang-cn

xiaofan-luan
xiaofan-luan reviewed Mar 17, 2026
View reviewed changes
vectordb_bench/models.py
cur_latency * 1000 if cur_latency > 0 else cur_latency
)

cur_latency = case_result["metrics"]["serial_latency_avg"]
Copy link
Copy Markdown
Collaborator

@xiaofan-luan xiaofan-luan Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a if check for backward compatibility

if "serial_latency_avg" in case_result["metrics"]

xiaofan-luan
xiaofan-luan reviewed Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@xiaofan-luan xiaofan-luan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fix needed. others looks good to me

@xiaofan-luan
Copy link
Copy Markdown
Collaborator

xiaofan-luan commented Mar 17, 2026

@ztorchan also please check the formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add avg serial latency output

3 participants

@ztorchan @sre-ci-robot @xiaofan-luan