Skip to content

fix: app details layout - WPB-24410#4523

Open
caldrian wants to merge 5 commits intofix/apps-search-results-empty-screen-WPB-24393from
fix/app-details-layout-WPB-24410
Open

fix: app details layout - WPB-24410#4523
caldrian wants to merge 5 commits intofix/apps-search-results-empty-screen-WPB-24393from
fix/app-details-layout-WPB-24410

Conversation

@caldrian
Copy link
Copy Markdown
Contributor

@caldrian caldrian commented Apr 1, 2026

BugWPB-24410 [iOS] App details not according to design - Align with right Design

Issue

This PR fixes the layout of the app details view.

Testing

Search for or list an app and/or a bot and tap it in the search results in order to view name, author, category and description.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian removed the WIP label Apr 1, 2026
@caldrian caldrian changed the title fix: app details layout - WPB-24410 fix: app details layout - WPB-24410x Apr 1, 2026
@caldrian caldrian changed the title fix: app details layout - WPB-24410x fix: app details layout - WPB-24410 Apr 1, 2026
@caldrian caldrian marked this pull request as ready for review April 1, 2026 12:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Test Results

1 877 tests   1 848 ✅  2m 5s ⏱️
  301 suites     27 💤
    1 files        2 ❌

For more details on these failures, see this check.

Results for commit 8d3bd7d.

♻️ This comment has been updated with latest results.

Summary: workflow run #23889986574
Allure report (download zip): html-report-29001-fix_app-details-layout-WPB-24410

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp bot commented Apr 1, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 2 Tests failed

testForTeamMemberWrappedInNavigationController() from Wire-iOS-Tests.ServiceDetailViewControllerSnapshotTests   View in Datadog   (Fix with Cursor)
ServiceDetailViewControllerSnapshotTests.swift:67: XCTAssertNil failed: "Snapshot does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/ServiceDetailViewControllerSnapshotTests/testForTeamMemberWrappedInNavigationController.1.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/ServiceDetailViewControllerSnapshotTests/testForTeamMemberWrappedInNavigationController.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...
testForTeamPartner() from Wire-iOS-Tests.ServiceDetailViewControllerSnapshotTests   View in Datadog   (Fix with Cursor)
ServiceDetailViewControllerSnapshotTests.swift:76: XCTAssertNil failed: "Snapshot does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/ServiceDetailViewControllerSnapshotTests/testForTeamPartner.1.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/ServiceDetailViewControllerSnapshotTests/testForTeamPartner.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8d3bd7d | Docs | Was this helpful? Give us feedback!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant