fix: Removed duplicated alert system. - WPB-23037 by JaCaLlaSchwarz · Pull Request #4492 · wireapp/wire-ios

JaCaLlaSchwarz · 2026-03-25T12:21:40Z

WPB-23037 [iOS] Duplicate initial system messages

Issue

Duplicated Alert warning message

Testing

Before After

Checklist

Title contains a reference JIRA issue number like [WPB-XXX].

Description is filled and free of optional paragraphs.

Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

Make sure you use the API for UI elements that support large fonts.

All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.

New UI elements have Accessibility strings for VoiceOver.

netbe

Left a couple comments, it's going towards the right direction but still need some changes before approval.

I would expect conversation snapshot test to change too somehow

wire-ios-request-strategy/Sources/Payloads/Processing/ConversationEventPayloadProcessor.swift

...Domain/Sources/WireDomain/Repositories/Conversations/LocalStore/ConversationLocalStore.swift

netbe · 2026-03-25T12:57:16Z

...OS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+Header.swift

            connectionViewController = UserConnectionViewController(userSession: userSession, user: otherParticipant)
            headerView = connectionViewController?.view
+        } else {
+            noUserConnectionViewController = NoUserConnectionViewController(userSession: userSession)


suggestion: I feel like the name of this view NoUserConnectionViewController is a bit misleading, as it's the header for groups or channels.

maybe DefaultConversationHeaderViewController, feel free to challenge this name ;)

netbe · 2026-03-25T13:01:40Z

...OS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+Header.swift


-        let connectionOrOneOnOne = conversation.conversationType == .connection || conversation
-            .conversationType == .oneOnOne
+        let connectionOrOneOnOne = [.connection, .oneOnOne /* , .group */ ]


suggestion: revert, this change is not necessary

netbe · 2026-03-25T13:05:01Z

...Domain/Sources/WireDomain/Repositories/Conversations/LocalStore/ConversationLocalStore.swift

        await context.perform { [self] in
-            if isInitialFetch {
-                // we just got a new conversation, we display new conversation header
-                localConversation.appendNewConversationSystemMessage(


issue: not inserting the new conversationsystemMessage is not enough (+ could be avoided). For current conversations the double system message would still show.

I suggest to not return a cell on the conversationContentViewController for the newConversation system message

github-actions · 2026-03-25T13:53:04Z

Test Results

1 876 tests 1 825 ✅ 2m 14s ⏱️
300 suites 27 💤
1 files 24 ❌

For more details on these failures, see this check.

Results for commit ad9b1be.

♻️ This comment has been updated with latest results.

Summary: workflow run #23837176590
Allure report (download zip): html-report-28952-fix_remove_duplicated_warning_message_WPB23037_v2

datadog-wireapp · 2026-03-25T17:25:57Z

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 24 Tests failed

testChannelHistoryDepthForNewConversation() from Wire-iOS-Tests.ConversationSystemMessageChannelHistoryDepthSnapshotTests

(Fix with Cursor)

ConversationSystemMessageChannelHistoryDepthSnapshotTests.swift:102: XCTAssertNil failed: "Snapshot "320.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/ConversationSystemMessageChannelHistoryDepthSnapshotTests/testChannelHistoryDepthForNewConversation.320-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/ConversationSystemMessageChannelHistoryDepthSnapshotTests/testChannelHistoryDepthForNewConversation.320-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

testThatItRendersNewConversationCell_SelfIsCollaborator_AllowGuests() from Wire-iOS-Tests.StartedConversationCellTests

(Fix with Cursor)

StartedConversationCellTests.swift:179: XCTAssertNil failed: "Snapshot "414.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/StartedConversationCellTests/testThatItRendersNewConversationCell_SelfIsCollaborator_AllowGuests.414-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/StartedConversationCellTests/testThatItRendersNewConversationCell_SelfIsCollaborator_AllowGuests.414-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

testThatItRendersNewConversationCell_SelfIsGuest_AllowGuests() from Wire-iOS-Tests.StartedConversationCellTests

(Fix with Cursor)

StartedConversationCellTests.swift:187: XCTAssertNil failed: "Snapshot "414.0" does not match reference.

@−
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/Wire-iOS Tests/ReferenceImages/StartedConversationCellTests/testThatItRendersNewConversationCell_SelfIsGuest_AllowGuests.414-0.png"
@+
"file:///Users/admin/actions-runner/_work/wire-ios/wire-ios/wire-ios/SnapshotResults/StartedConversationCellTests/testThatItRendersNewConversationCell_SelfIsGuest_AllowGuests.414-0.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
...

View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ad9b1be | Docs | Was this helpful? Give us feedback!}

…23037_v2

…ithub.com:wireapp/wire-ios into fix/remove_duplicated_warning_message_WPB23037_v2

…23037_v2

samwyndham · 2026-03-27T09:22:29Z

FYI I'll wait for the issues @netbe raised to be addressed before review.

netbe

still some issues are there, please reply to my comments before re-asking for review

netbe · 2026-03-30T07:54:52Z

...ent/Cells/ConfigurationMessageCell/Components/ConversationSystemMessageCellDescription.swift

            cells.append(AnyConversationMessageCellDescription(startedConversationCell))

            // Only display invite user cell for team members
            if selfUser.isTeamMember,
               conversation.selfCanAddUsers(selfUser: selfUser),
               conversation.isOpenGroup {
                cells.append(
                    AnyConversationMessageCellDescription(
                        GuestsAllowedCellDescription(isChannel: conversation.isChannel)
                    )
                )
            }

            if conversation.isWireDriveEnabled {
                let fileCollaborationCell = ConversationFileCollaborationSystemMessageCellDescription()
                cells.append(AnyConversationMessageCellDescription(fileCollaborationCell))


thought: I wonder if all the cells here should move to header

netbe · 2026-03-30T07:56:41Z

...estThatItRendersNewConversationCellStartedFromSelfWithOneParticipantAndWithoutName.414-0.png

issue: there seems to be a git lfs issue here, try:

git lfs migrate import --no-rewrite --yes wire-ios/Wire-iOS Tests/ReferenceImages/StartedConversationCellTests/testThatItRendersNewConversationCellStartedFromSelfWithOneParticipantAndWithoutName.414-0.png

netbe · 2026-03-30T07:57:43Z

.../Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationContentViewController.swift

    let selfProfileUIBuilder: SelfProfileViewControllerBuilderProtocol
    let conversationCreationRepository: any ConversationCreationRepositoryProtocol
    var connectionViewController: UserConnectionViewController?
+    var             defaultConversationHeaderViewController: DefaultConversationHeaderViewController?


Suggested change

var defaultConversationHeaderViewController: DefaultConversationHeaderViewController?

var defaultConversationHeaderViewController: DefaultConversationHeaderViewController?

…testThatItRendersNewConversationCellStartedFromSelfWithOneParticipantAndWithoutName.414-0.png: convert to Git LFS

…23037_v2

…ithub.com:wireapp/wire-ios into fix/remove_duplicated_warning_message_WPB23037_v2

…23037_v2

sonarqubecloud · 2026-04-01T07:34:22Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

samwyndham

Nice work. I've left a few questions questions/change requests regarding some UIKit points.

samwyndham · 2026-04-01T07:29:11Z

wire-ios/Wire-iOS/Sources/UserInterface/ConnectRequests/DefaultConversationHeaderView.swift

+
+final class DefaultConversationHeaderView: UIView {
+
+    private static var correlationFormatter: AddressBookCorrelationFormatter = .init(


question: Is this used anywhere?

samwyndham · 2026-04-01T07:33:28Z

wire-ios/Wire-iOS/Sources/UserInterface/ConnectRequests/DefaultConversationHeaderView.swift

+            guestWarningContainer.leadingAnchor.constraint(equalTo: leadingAnchor, constant: 0),
+            guestWarningContainer.trailingAnchor.constraint(equalTo: trailingAnchor, constant: 0),


suggestion: Sorry I'm forgetting UIKit :). Is the constant needed? I think if you remove the constant parameter it will be the same (like what you are doing with the top and bottom anchors)

samwyndham · 2026-04-01T07:35:19Z

wire-ios/Wire-iOS/Sources/UserInterface/ConnectRequests/DefaultConversationHeaderView.swift

+    )
+
+    private let guestWarningView = GuestAccountWarningView()
+    private let guestWarningContainer = UIView()


question: What is the purpose of guestWarningContainer. Can't guestWarningView be added directly to self as DefaultConversationHeaderView is also a view.

samwyndham · 2026-04-01T07:37:06Z

...Wire-iOS/Sources/UserInterface/ConnectRequests/DefaultConversationHeaderViewController.swift

+
+    fileprivate var defaultConversationHeaderView: DefaultConversationHeaderView!
+
+    let userSession: ZMUserSession


question: How is this property used?

samwyndham · 2026-04-01T07:38:56Z

...Wire-iOS/Sources/UserInterface/ConnectRequests/DefaultConversationHeaderViewController.swift

+
+final class DefaultConversationHeaderViewController: UIViewController {
+
+    fileprivate var defaultConversationHeaderView: DefaultConversationHeaderView!


suggestion: This property isn't accessed so it is not needed. Instead you can do:

override func loadView() { view = DefaultConversationHeaderView() }

samwyndham · 2026-04-01T07:43:12Z

...OS/Sources/UserInterface/Conversation/Content/ConversationContentViewController+Header.swift

+            defaultConversationHeaderViewController = DefaultConversationHeaderViewController(userSession: userSession)
+            headerView = defaultConversationHeaderViewController?.view


question: What is the need for the existence of DefaultConversationHeaderViewController? This view controller doesn't seem to do anything. My guess is we can delete DefaultConversationHeaderViewController and just use DefaultConversationHeaderView directly.

JaCaLlaSchwarz requested a review from johnxnguyen March 25, 2026 12:21

github-actions bot assigned JaCaLlaSchwarz Mar 25, 2026

github-actions bot added the Fix PR Title 🤦‍♂️ label Mar 25, 2026

JaCaLlaSchwarz requested review from netbe and samwyndham March 25, 2026 12:21

JaCaLlaSchwarz changed the title ~~fix: Removed duplicated alert system. WPB - 23037~~ fix: Removed duplicated alert system. WPB-23037 Mar 25, 2026

JaCaLlaSchwarz changed the title ~~fix: Removed duplicated alert system. WPB-23037~~ fix: Removed duplicated alert system. - WPB-23037 Mar 25, 2026

JaCaLlaSchwarz removed the Fix PR Title 🤦‍♂️ label Mar 25, 2026

netbe requested changes Mar 25, 2026

View reviewed changes

JaCaLlaSchwarz requested a review from netbe March 25, 2026 15:30

JaCaLlaSchwarz added 3 commits March 25, 2026 17:54

fix: Removed duplicated alert system. WPB - 23037

dba42d9

Address PR comments

1b3722d

Address PR comment

ae6308f

JaCaLlaSchwarz force-pushed the fix/remove_duplicated_warning_message_WPB23037_v2 branch from 90c22a2 to ae6308f Compare March 25, 2026 16:55

JaCaLlaSchwarz added 5 commits March 26, 2026 15:48

Fix snapshot tests

7d17110

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

8d9c32e

…23037_v2

Fix unit test

ebbfa4f

Merge branch 'fix/remove_duplicated_warning_message_WPB23037_v2' of g…

143be0a

…ithub.com:wireapp/wire-ios into fix/remove_duplicated_warning_message_WPB23037_v2

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

0071777

…23037_v2

netbe requested changes Mar 30, 2026

View reviewed changes

JaCaLlaSchwarz added 4 commits March 30, 2026 11:07

Address PR comment

6d07515

wire-ios/Wire-iOS Tests/ReferenceImages/StartedConversationCellTests/…

1f5a128

…testThatItRendersNewConversationCellStartedFromSelfWithOneParticipantAndWithoutName.414-0.png: convert to Git LFS

Address PR Comment

5e83a28

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

bfb3114

…23037_v2

JaCaLlaSchwarz requested a review from netbe March 30, 2026 09:41

JaCaLlaSchwarz added 2 commits March 30, 2026 11:56

Reverted commit.

d0fe60d

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

2269382

…23037_v2

JaCaLlaSchwarz and others added 7 commits March 30, 2026 16:19

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

c2d6793

…23037_v2

Revert unit test

8869197

Merge branch 'fix/remove_duplicated_warning_message_WPB23037_v2' of g…

8ac765f

…ithub.com:wireapp/wire-ios into fix/remove_duplicated_warning_message_WPB23037_v2

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

51bdc7d

…23037_v2

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

005283a

…23037_v2

Merge branch 'develop' into fix/remove_duplicated_warning_message_WPB…

c2f9ee3

…23037_v2

wip TODO move the cells to header

ad9b1be

samwyndham requested changes Apr 1, 2026

View reviewed changes

	var defaultConversationHeaderViewController: DefaultConversationHeaderViewController?
	var defaultConversationHeaderViewController: DefaultConversationHeaderViewController?


		final class DefaultConversationHeaderView: UIView {

		private static var correlationFormatter: AddressBookCorrelationFormatter = .init(

		guestWarningContainer.leadingAnchor.constraint(equalTo: leadingAnchor, constant: 0),
		guestWarningContainer.trailingAnchor.constraint(equalTo: trailingAnchor, constant: 0),


		fileprivate var defaultConversationHeaderView: DefaultConversationHeaderView!

		let userSession: ZMUserSession

		defaultConversationHeaderViewController = DefaultConversationHeaderViewController(userSession: userSession)
		headerView = defaultConversationHeaderViewController?.view

Conversation

JaCaLlaSchwarz commented Mar 25, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Testing

Checklist

UI accessibility checklist

Uh oh!

netbe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

datadog-wireapp bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

samwyndham commented Mar 27, 2026

Uh oh!

netbe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Quality Gate failed

Uh oh!

samwyndham left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JaCaLlaSchwarz commented Mar 25, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading

datadog-wireapp bot commented Mar 25, 2026 •

edited

Loading