chore: adding tags to the UITests - WPB-20997#3933
Conversation
Test Results1 883 tests 1 856 ✅ 2m 4s ⏱️ Results for commit fde932d. ♻️ This comment has been updated with latest results. Summary: workflow run #23191605547 |
netbe
left a comment
There was a problem hiding this comment.
interesting way to use kind of "tags" in XCTest as it would be in SwiftTesting. For our usecase, I wonder if it's worth it to have this rather to rely on a specific testplan that would contain the critical tests: the same way we have security tests.
what do you think @johnxnguyen ?
It's a shame that you can't add tags to XCTest cases like can for Swift Testing as that would be the preferred approach. For me, the better solution for XCTests is to have specific test plans (note that a single test can be in multiple test plans) as this will make it easier for people to read and it aligns with what we currently do already. I'd be cautious about adding additional variations for organizing and running tests. |
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
|
@findms should we close this? @johnxnguyen |
|
@netbe @johnxnguyen |
|



Summary
Briefly describe about this PR changes.
Configuration for critical test run added so basically it check if test name has critical(ignore casing) then running critical testplan will run all the tests which has critical word, if running normal configuration(as before) it will run all tests.
Testing
Describe how to verify the changes locally. Attach screenshots of local execution if relevant.
tests name updated with critical like this

On running test using command
bundle exec fastlane run_uitests configuration:UITest-critical, only test with critical word will run not others.Additional Information
any more info, add here.
How to run?
To run tests marked with tags critical here is the command:
bundle exec fastlane run_uitests configuration:UITest-criticalif configuration is not being passed, it will run all tests as regression.
bundle exec fastlane run_uitests