Skip to content

Enhance menu bar documentation on icons and variants#5447

Open
rodolforfq wants to merge 2 commits intov24from
menu-items-icons-variants
Open

Enhance menu bar documentation on icons and variants#5447
rodolforfq wants to merge 2 commits intov24from
menu-items-icons-variants

Conversation

@rodolforfq
Copy link
Copy Markdown
Contributor

Added guidance on using MenuBarVariant for drop-down indicators and icon-only menu items. Based con customer's feedback.

Added guidance on using MenuBarVariant for drop-down indicators and icon-only menu items. Based con customer's feedback.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 3, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

AI Language Review

The only notable change is the addition of text mentioning the use of MenuBarVariant.LUMO_DROPDOWN_INDICATORS and MenuBarVariant.LUMO_ICON for styling menu items. There are no issues requiring improvement in the updated version.

Corrected a typo in the documentation regarding drop-down menus and icon usage.
Copy link
Copy Markdown
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure I follow the logic implied by the additional sentences. In what cases should drop-down indicators be used? And I don't think the LUMO_ICON variant hides the drop-down indicators.

Also, as the guidance here is Lumo-specific and doesn't apply to base styles or Aura at all, I would like to avoid theme-specific guidance in the main component docs page. Theme-specific things would be more suitable on the Styling sub-page.

Based con customer's feedback.

What was the feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants