Enhance menu bar documentation on icons and variants#5447
Enhance menu bar documentation on icons and variants#5447rodolforfq wants to merge 2 commits intov24from
Conversation
Added guidance on using MenuBarVariant for drop-down indicators and icon-only menu items. Based con customer's feedback.
AI Language ReviewThe only notable change is the addition of text mentioning the use of |
Corrected a typo in the documentation regarding drop-down menus and icon usage.
jouni
left a comment
There was a problem hiding this comment.
I’m not sure I follow the logic implied by the additional sentences. In what cases should drop-down indicators be used? And I don't think the LUMO_ICON variant hides the drop-down indicators.
Also, as the guidance here is Lumo-specific and doesn't apply to base styles or Aura at all, I would like to avoid theme-specific guidance in the main component docs page. Theme-specific things would be more suitable on the Styling sub-page.
Based con customer's feedback.
What was the feedback?
Added guidance on using MenuBarVariant for drop-down indicators and icon-only menu items. Based con customer's feedback.