Closed
Conversation
Contributor
Author
|
I'll close this one for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: treat empty Authorization header as absent in S3 signature extraction.
extractSignature()insrc/http/plugins/signature-v4.tsdetermines where S3 credentials are located by checking three sources as follows:Authorizationheader → parse as AWS Signature V4 (AWS4-HMAC-SHA256 Credential=...)X-Amz-Credentialquery parameter → parse as presigned URLThe check for step 1 uses
typeof req.headers.authorization === 'string', which matches an empty string. An emptyAuthorizationheader entersparseAuthorizationHeader, which immediately fails with "Unsupported authorization type" because"".split(' ')[0]is not AWS4-HMAC-SHA256. Steps 2 and 3 are never reached.This means any request that carries credentials in the query string (presigned URLs) or form fields (multipart POST) will fail if a reverse proxy or API gateway injects an empty
Authorizationheader.Empty string is never a valid AWS Signature V4 authorization value. The fix adds
&& req.headers.authorization !== ''to the check, so empty headers fall through to query string and multipart parsing as intended.