[7.x] Add $unique argument to Asset::move()#14364
Open
lwekuiper wants to merge 1 commit intostatamic:masterfrom
Open
[7.x] Add $unique argument to Asset::move()#14364lwekuiper wants to merge 1 commit intostatamic:masterfrom
lwekuiper wants to merge 1 commit intostatamic:masterfrom
Conversation
lwekuiper
changed the title
jasonvarga
requested changes
Mar 26, 2026
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
First v7 PR! 🎉
I've just brought master up to date with 6.x if you'd like to fix the conflicts and remove the moveUnique method. (or reopen the PR if that's easier for you)
lwekuiper
force-pushed
the
feat/asset-move-unique-arg
branch
from
53edf63 to
4b7a508
Compare
Contributor
Author
That's actually pretty cool 🥳 The PR is now updated! |
jasonvarga
requested changes
Mar 27, 2026
Member
jasonvarga
left a comment
jasonvarga
left a comment
There was a problem hiding this comment.
There's a bunch of unnecessary formatting changes. (e.g. added newlines, renaming unrelated test methods with_events->withEvents).
The moveQuietly method also needs the $unique parameter. Technically it works because it forwards arguments but it should be added.
Remove moveUnique() in favor of a $unique parameter on move(), consistent with how rename() already works. Add $unique parameter to moveQuietly() signature for explicit API parity.
lwekuiper
force-pushed
the
feat/asset-move-unique-arg
branch
from
4b7a508 to
5c35199
Compare
Contributor
Author
|
Right, that was my automatic Pint formatting, I'll make sure to skip this in future PRs. This is now cleaned up and the $unique parameter is added to moveQuietly(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #14236, which added
Asset::moveUnique()as a non-breaking addition for 6.x.Since
masterallows breaking changes, this PR removesmoveUnique()and adds a$uniqueparameter directly toAsset::move(), consistent with howAsset::rename()already works: