chore: migrate to stackit-sdk-go v1api and update API calls#49
Open
chore: migrate to stackit-sdk-go v1api and update API calls#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Stackit DNS provider integration to use the new
v1apiclient from thestackit-sdk-golibrary, and refactors the codebase to work with the updated API types and structures. The changes remove the use of pointer-based fields in favor of direct values, streamline record and zone handling, and update all relevant tests accordingly.Key changes include:
Migration to v1api client and updated types:
github.com/stackitcloud/stackit-sdk-go/services/dnstogithub.com/stackitcloud/stackit-sdk-go/services/dns/v1apiacross the codebase and tests to use the updated API client. [1] [2] [3] [4] [5]stackit-sdk-go/services/dnsv0.19.2, which includes the newv1api.Refactoring for new API data structures:
zone.Idinstead of*zone.Id,zone.DnsNameinstead of*zone.DnsName). [1] [2] [3] [4]Name,Type,Ttl, andRecords. [1] [2]API method usage updates:
DefaultAPIinterface provided byv1api, and adjusted parameter passing to use direct values. [1] [2] [3]Test updates for new types and structures:
These changes collectively modernize the Stackit DNS provider codebase, ensuring compatibility with the latest SDK version and improving code clarity and maintainability.