fix memory leak issue#292
Open
WilliamLiu-1997 wants to merge 2 commits intosparkjsdev:v2.0.0-previewfrom
Open
Conversation
Open
Author
|
Here are examples: Example that fixed memory leak Example that show memory leak (you can see the memory usage in red memory panel, in this example, as you look around, zoom in/out, the memory usage will keep inscreasing) Memory Leak Example
### Memory Leak Fixed Example
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Memory Leak Fix
Incomplete or missing
dispose()methods cause GPU resources and large typed arrays to leak whenSplatMeshinstances are destroyed.Changes
DynoPrograms,SplatEdits,SplatSkinning,RgbaArray, LoD state, context refs, modifiers, and callbacks. Also clean up caches on generator rebuild.unregisterMesh()to clean up LoD entries from all active renderers.sh1–sh3), clearextArraysandextra.packedArray, clearextra.releaseGeneratorProgram()to evict and dispose cachedDynoProgramfrom static maps.dispose()to release associatedShaderMaterial.dispose()to release SDFDataArrayTexture.dispose()to release skin/boneDataTextures.