Created TranslationLanguagePickerView.swift. It now uses a modern Swi…#641
Open
Vishuzz wants to merge 3 commits intoscribe-org:mainfrom
Open
Created TranslationLanguagePickerView.swift. It now uses a modern Swi…#641Vishuzz wants to merge 3 commits intoscribe-org:mainfrom
Vishuzz wants to merge 3 commits intoscribe-org:mainfrom
Conversation
…ftUI List with inset-grouped styling to match the native iOS settings feel.
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local Scribe-iOS repo (can be set withgit config --global user.email "GITHUB_EMAIL")
…ranslation source selection.
… by converting the root Settings screen and removing the remaining UIKit-based implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ftUI List with inset-grouped styling to match the native iOS settings feel.
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Convert the Keyboard app Settings tab from UIKit to SwiftUI, following the architecture introduced in #609.
Key Changes
• Added a new SwiftUI settings view for the Keyboard app using List with .insetGrouped styling to match native iOS Settings.
• Recreated existing settings submenus in SwiftUI.
• Updated navigation flow to present the new SwiftUI view through UIHostingController.
• Resolved type ambiguity between SwiftUI.Section and project-specific Scribe.Section.
• Removed obsolete UIKit-based settings components that are no longer required.
Cleanup
• Removed deprecated UIKit view/controller files related to the previous settings implementation.
• Deleted unused storyboard references associated with the old Settings tab.
Related issue
Closes #610