Skip to content

Add index to key animation#632

Open
henrikth93 wants to merge 3 commits intoscribe-org:mainfrom
henrikth93:henrikt93-#510
Open

Add index to key animation#632
henrikth93 wants to merge 3 commits intoscribe-org:mainfrom
henrikth93:henrikt93-#510

Conversation

@henrikth93
Copy link
Copy Markdown
Member

This commit will add an index variable so we can differentiate between keys that share the same character.

Contributor checklist


Description

Related issue

This commit will add an index variable so we can differentiate between keys that share the same character.
@github-actions
Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and iOS rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Copy Markdown
Member

@henrikth93, would it not be more sensible to do a full switch over the indexes for this? I think that that would be a much more sustainable solution here. The way that the keys are derived via the arrays of keys on the left and keys on the right is from right when Scribe-iOS was first developed. Really not the best (being the author myself) 😅

How does this sound:

  • We remove leftKeyChars, rightKeyChars and centralKeyChars from all interface variable files
  • We rework the way that the popups are being shown based on the indexes of the keys being the first index for left, the last index for right, and other indexes for center
    • We would have some minor edge cases like for keyboards where the middle row has spacing to the left and right like Portuguese, where in that case we'd like a centered popup

How does the above sound? If so, you could do edits to this PR and we could bring it in! 🚀

This commit will remove left, center and rich character check
This commit will remove an unused variable (row) and remove some code that was "commented out".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants