Conversation
This commit will add an index variable so we can differentiate between keys that share the same character.
Thank you for the pull request! 💙🩵The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
@henrikth93, would it not be more sensible to do a full switch over the indexes for this? I think that that would be a much more sustainable solution here. The way that the keys are derived via the arrays of keys on the left and keys on the right is from right when Scribe-iOS was first developed. Really not the best (being the author myself) 😅 How does this sound:
How does the above sound? If so, you could do edits to this PR and we could bring it in! 🚀 |
This commit will remove left, center and rich character check
This commit will remove an unused variable (row) and remove some code that was "commented out".
This commit will add an index variable so we can differentiate between keys that share the same character.
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Related issue