fix(iscsiadm): separate merged options (--logoutall--show → --logoutall --show)#1612
Open
fix(iscsiadm): separate merged options (--logoutall--show → --logoutall --show)#1612
Conversation
yedayak
reviewed
Apr 5, 2026
a1d803a to
e8d32e0
Compare
Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect option concatenation in
iscsiadmbash completion.In
nodemode, the options--logoutalland--showare incorrectly merged in the completion script as:--logoutall--show
This happens due to a missing space between the two options in:
completions-core/iscsiadm.bashFixes #1611
Problem
Because of this concatenation:
--logoutall--showas a single invalid optionFix
This patch separates the options correctly by adding a space: