Skip to content

fix(iscsiadm): separate merged options (--logoutall--show → --logoutall --show)#1612

Open
ADI2705 wants to merge 2 commits intoscop:mainfrom
ADI2705:fix-iscsiadm-completion
Open

fix(iscsiadm): separate merged options (--logoutall--show → --logoutall --show)#1612
ADI2705 wants to merge 2 commits intoscop:mainfrom
ADI2705:fix-iscsiadm-completion

Conversation

@ADI2705
Copy link
Copy Markdown

@ADI2705 ADI2705 commented Apr 4, 2026

Description

Fix incorrect option concatenation in iscsiadm bash completion.

In node mode, the options --logoutall and --show are incorrectly merged in the completion script as:
--logoutall--show

This happens due to a missing space between the two options in:
completions-core/iscsiadm.bash


Fixes #1611

Problem

Because of this concatenation:

  • Bash treats --logoutall--show as a single invalid option
  • Tab completion suggestions become incorrect
  • In some cases, repeated or malformed completions may be inserted into the command line

Fix

This patch separates the options correctly by adding a space:

- --logoutall--show
+ --logoutall --show

@ADI2705 ADI2705 changed the title iscsiadm: fix merged options (--logoutall--show → --logoutall --show) fix(iscsiadm): separate merged options (--logoutall--show → --logoutall --show) Apr 6, 2026
@ADI2705 ADI2705 force-pushed the fix-iscsiadm-completion branch from a1d803a to e8d32e0 Compare April 6, 2026 08:24
Co-authored-by: Yedaya Katsman <yedaya.ka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iscsiadm completion: incorrect option formatting (--logoutall--show)

2 participants