sys-var: clarify tidb_slow_log_rules syntax/behavior and de-duplicate slow log docs#22567
sys-var: clarify tidb_slow_log_rules syntax/behavior and de-duplicate slow log docs#22567hfxsd wants to merge 11 commits intopingcap:masterfrom
tidb_slow_log_rules syntax/behavior and de-duplicate slow log docs#22567Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the clarity and accuracy of the documentation for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request description indicates significant documentation updates for tidb_slow_log_rules. However, the provided changes only consist of adding a temp.md file, which seems unrelated to the stated purpose and appears to be a temporary file. This file should be removed from the pull request to ensure the changes accurately reflect the PR's goal. My review includes a minor suggestion for this file in case its inclusion is intentional.
Synced from: pingcap/docs-cn#21337 Target PR: pingcap#22567 AI Provider: gemini Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…tps://github.com/hfxsd/docs into docs/tidb_slow_log_rules-doc-improve-21324-21337
…tps://github.com/hfxsd/docs into docs/tidb_slow_log_rules-doc-improve-21324-21337
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
This PR refactors and clarifies
tidb_slow_log_rulesdocumentation in:system-variables.mdidentify-slow-queries.mdMain updates:
Reorganized
tidb_slow_log_rulesinsystem-variables.mdwith clearer structure:Clarified key behavior/constraints:
Conn_ID(GLOBAL only)>=for numeric,=for string/bool)tidb_slow_log_thresholdwhen no effective rules,/;(quoted values still not supported)tidb_slow_log_rulestime fields are seconds, threshold is milliseconds)Reduced duplication between docs:
system-variables.mdidentify-slow-queries.mdWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
tidb_slow_log_rulessyntax/behavior and de-duplicate slow log docs docs-cn#21337Do your changes match any of the following descriptions?