Open
Conversation
Introduce command mode in the omni bar. Features: - Launch with ':' (default key mapping). - Support prefix counts. - Show all commands (even mapped ones). - Show all commands as specified (with any options) in user defined key mappings. - Show keys for mapped commands, similarly to the help page. Fix: - Fix collection of unit tests in subdirectories. Other: - Revise 'noRepeat' attribute for all commands.
Owner
|
Whoa, very exciting! Thank you for the PR. I'll take this for a spin in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce command mode in the omni bar.
Features:
Fix:
Other:
Description
Good evening, this MR implements feature request #4103.
I have tried to implement this feature as cleanly as possible.
I understand that this is quite a big patch, so I expect some changes based on reviewer suggestions,
but I think that it is working nicely.
I tried to add some tests, as well, but I am afraid I am not very familiar with
shouldaandpuppeteer,so I am not sure if I have followed best practices and if I am inside the general spirit of the Vimium tests.
I am looking forward to your feedback and hope to be merging this soon.