Add missing integration tests to CI and fix json.Number assertions#102
Add missing integration tests to CI and fix json.Number assertions#102
Conversation
Fix TestRepsetDiff_DivergentTable and TestRepsetDiff_MultipleTables
which compared float64(99) against json.Number("99") — broken since
OrderedMap.UnmarshalJSON started using dec.UseNumber() for bigint
precision.
Add CI steps for repset-diff, schema-diff, Merkle numeric scale
invariance, catastrophic single-node failure recovery, and timestamp
comparison tests that were not being run.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe GitHub Actions CI workflow was expanded to run multiple integration test steps instead of a single test. Test assertions in the diff test were updated to expect Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix TestRepsetDiff_DivergentTable and TestRepsetDiff_MultipleTables which compared float64(99) against json.Number("99") — broken since OrderedMap.UnmarshalJSON started using dec.UseNumber() for bigint precision.
Add CI steps for repset-diff, schema-diff, Merkle numeric scale invariance, catastrophic single-node failure recovery, and timestamp comparison tests that were not being run.