Skip to content

fix: Avoid double read from hb_cache when returns not_found#790

Open
speeddragon wants to merge 5 commits intoneo/edgefrom
impr/404_origin
Open

fix: Avoid double read from hb_cache when returns not_found#790
speeddragon wants to merge 5 commits intoneo/edgefrom
impr/404_origin

Conversation

@speeddragon
Copy link
Copy Markdown
Collaborator

@speeddragon speeddragon commented Mar 24, 2026

dev_name does a hb_cache:read call that goes through all the configured stores. In a case of a not_found, we continue with the request and ignore the result.

Problem:

  • If we know other hooks can turn this 404 into a 200, we should close this PR.
  • If we want to avoid duplicate calls to the stores, we should return as soon as possible. In the end, we can add an option to toggle this behaviour.

@speeddragon speeddragon marked this pull request as ready for review March 25, 2026 10:41
@speeddragon speeddragon changed the title fix: Avoid double read from hb_cache fix: Avoid double read from hb_cache when returns not_found Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant