[FEATURE REQUEST] Add action to check source strings#4807
Merged
Conversation
jesmrec
force-pushed
the
feature/add_action_check_source_strings
branch
4 times, most recently
from
7689a00 to
4bc6ef4
Compare
jesmrec
force-pushed
the
feature/add_action_check_source_strings
branch
2 times, most recently
from
1fa16c4 to
cf3a224
Compare
joragua
changed the title
jesmrec
force-pushed
the
feature/add_action_check_source_strings
branch
from
a499e9f to
4bf06c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two actions were addressed here:
In the
strings.xmlfile, some tiny changes to normalize the file against the validation script: remove some useless line breaks, and replace"for the escaped\"The action will run a script to check if every string in
strings.xmlcontains any forbidden character (non-escaped). The list of forbidden characters is set inside the script (i expect the list to be very static). The utilxmlstarletwill be used to parse the xml file and provide every entry one by one by using the process substitution operationFor the moment, the check will not be mandatory. Let's give a try, and, if it works fine, we could become mandatory
Related Issues
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA