nirfsg: Synchronize API updates with latest driver#2169
Merged
Conversation
rahur-NI
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
rahur-NI
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
- Coverage 90.13% 89.98% -0.15%
==========================================
Files 71 71
Lines 18669 18711 +42
==========================================
+ Hits 16827 16838 +11
- Misses 1842 1873 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
vnktshr21
reviewed
Mar 13, 2026
Collaborator
vnktshr21
left a comment
vnktshr21
left a comment
There was a problem hiding this comment.
List down the newly added APIs in PR description and update changelog as well.
vnktshr21
requested changes
Mar 13, 2026
rahur-NI
changed the title
rahur-NI
changed the title
vnktshr21
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR synchronizes with latest API updates included for nirfsg. These updates are also necessary since the latest gRPC-device proto that will be used for adding gRPC support already contains these.
get_script- Retrieves the content of a compiled script by namedelete_script- Deletes a script from memorySCRIPTSadded to enumLoadOptionsDO_NOT_DRIVE_SIGNALadded to enumPulseModulationSourceList issues fixed by this Pull Request below, if any.
What testing has been done?
test_get_scriptandtest_delete_scriptfor recently addedget_scriptanddelete_scriptAPIs and these tests are passing on real hardware. These are expected to be skipped on simulated devices.