Skip to content

refactor: Migrate components for Vue 3 compatibility #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Chartman123 wants to merge 20 commits into
base: main
Choose a base branch
from
+1,292 −2,129
Draft

refactor: Migrate components for Vue 3 compatibility #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
47307a6
chore: update dependencies and refactor components for Vue 3 compatib…
Chartman123 Oct 14, 2025
eda5e3f
run lint:fix
Chartman123 Feb 12, 2026
54ab624
fix: Patch vuedraggable and fix template refs for Vue 3 compatibility
nfebe Mar 4, 2026
f0a7a5c
fix sorting in package.json and add license for patch file
Chartman123 Mar 10, 2026
1f3acd1
try to fix e2e tests
Chartman123 Mar 10, 2026
12f6a0e
use vue-draggable-plus
Chartman123 Mar 23, 2026
97c67d8
fix(e2e): align a11y test beforeEach with established pattern
pringelmann Mar 25, 2026
80a5b5e
fix: replace v-click-outside with vOnClickOutside from @vueuse/compon…
pringelmann Mar 25, 2026
3820e57
fix: guard PillMenu against undefined currentView on initial render
pringelmann Mar 25, 2026
12aeb2e
fix: remove duplicated 'Limit number of responses' block in settings …
pringelmann Mar 25, 2026
6415d0c
fix: align SettingsSidebarTab event name with SharingSidebarTab
pringelmann Mar 25, 2026
c3af988
fix: markRaw PQueue instance in AnswerInput to prevent Vue 3 proxy error
pringelmann Mar 25, 2026
61b3f48
fix: pass index to update:answer emit in createLocalAnswer
pringelmann Mar 25, 2026
797512b
fix: use $props instead of Vue 2 vnode.componentOptions.propsData
pringelmann Mar 25, 2026
7940fb8
fix: prevent duplicate options and broken focus on answer creation
pringelmann Mar 25, 2026
811a63d
fix: migrate QuestionGrid draggable to vue-draggable-plus pattern
pringelmann Mar 25, 2026
3b57601
chore: remove unused pinia dep
pringelmann Mar 25, 2026
2ce99a2
chore: remove patch-package leftover from package.json
pringelmann Mar 25, 2026
049509f
fix: use @update:modelValue on NcSelect in QuestionDropdown
pringelmann Mar 25, 2026
fd5adc3
fix: e2e test regressions from Vue 3 migration
pringelmann Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions REUSE.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
# SPDX-FileCopyrightText: 2024-2026 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: AGPL-3.0-or-later
version = 1
SPDX-PackageName = "forms"
Expand All @@ -8,25 +8,25 @@ SPDX-PackageDownloadLocation = "https://github.com/nextcloud/forms"
[[annotations]]
path = ["l10n/**.js", "l10n/**.json", "js/**.js.map", "js/**.js"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2019-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-FileCopyrightText = "2019-2026 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "AGPL-3.0-or-later"

[[annotations]]
path = ["composer.json", "composer.lock"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2019-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-FileCopyrightText = "2019-2026 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "AGPL-3.0-or-later"

[[annotations]]
path = ["package-lock.json", "package.json"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2018-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-FileCopyrightText = "2018-2026 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "AGPL-3.0-or-later"

[[annotations]]
path = ["vendor-bin/psalm/composer.json", "vendor-bin/psalm/composer.lock"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2018-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-FileCopyrightText = "2018-2026 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "AGPL-3.0-or-later"

[[annotations]]
Expand All @@ -38,7 +38,7 @@ SPDX-License-Identifier = "CC0-1.0"
[[annotations]]
path = ["vendor-bin/cs-fixer/composer.json", "vendor-bin/cs-fixer/composer.lock", "vendor-bin/psalm/composer.json", "vendor-bin/psalm/composer.lock", "vendor-bin/openapi-extractor/composer.json", "vendor-bin/openapi-extractor/composer.lock", "openapi.json"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2021-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-FileCopyrightText = "2021-2026 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "AGPL-3.0-or-later"

[[annotations]]
Expand All @@ -56,11 +56,17 @@ SPDX-License-Identifier = "AGPL-3.0-or-later"
[[annotations]]
path = ["img/*"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2018-2024 Google LLC, 2016-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-FileCopyrightText = "2018-2026 Google LLC, 2016-2024 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "Apache-2.0"

[[annotations]]
path = ["screenshots/*"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2023 Christian Hartmann <chris-hartmann@gmx.de>"
SPDX-License-Identifier = "AGPL-3.0-or-later"

[[annotations]]
path = ["patches/*"]
precedence = "aggregate"
SPDX-FileCopyrightText = "2026 Nextcloud GmbH and Nextcloud contributors"
SPDX-License-Identifier = "AGPL-3.0-or-later"
4 changes: 2 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { recommendedVue2 } from '@nextcloud/eslint-config'
import { recommended } from '@nextcloud/eslint-config'
import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended'

export default [
...recommendedVue2,
...recommended,
eslintPluginPrettierRecommended,
{
rules: {
Expand Down
Loading
Loading