Conversation
There was a problem hiding this comment.
Pull request overview
Adds optional Gateway API HTTPRoute support to the Netdata Helm chart so the web UI can be exposed via HTTPRoute instead of (or in addition to) Ingress.
Changes:
- Introduces new
httpRoute.*values (enablement, labels/annotations, parentRefs, hostnames, rules). - Adds a new
templates/parent/httproute.yamlto render anHTTPRoutewhen enabled. - Updates the chart README values table to document the new configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/netdata/values.yaml | Adds httpRoute configuration block and defaults. |
| charts/netdata/templates/parent/httproute.yaml | New HTTPRoute manifest template gated by parent.enabled and httpRoute.enabled. |
| charts/netdata/README.md | Documents the new httpRoute.* values in the generated table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| apiVersion: gateway.networking.k8s.io/v1 |
There was a problem hiding this comment.
apiVersion is hard-coded to gateway.networking.k8s.io/v1, which will make httpRoute.enabled=true fail to install on clusters that only have HTTPRoute served as v1beta1 (common depending on the installed Gateway API CRDs). Consider selecting the apiVersion based on .Capabilities.APIVersions.Has (or making it configurable via Values.httpRoute.apiVersion) similar to how the chart handles Ingress apiVersion selection.
| apiVersion: gateway.networking.k8s.io/v1 | |
| {{- $httpRouteApiVersion := "gateway.networking.k8s.io/v1" -}} | |
| {{- if not (.Capabilities.APIVersions.Has "gateway.networking.k8s.io/v1/HTTPRoute") -}} | |
| {{- if .Capabilities.APIVersions.Has "gateway.networking.k8s.io/v1beta1/HTTPRoute" -}} | |
| {{- $httpRouteApiVersion = "gateway.networking.k8s.io/v1beta1" -}} | |
| {{- end -}} | |
| {{- end -}} | |
| apiVersion: {{ $httpRouteApiVersion }} |
There was a problem hiding this comment.
The concern is technically valid but has a low practical impact in 2026. Gateway API v1 (HTTPRoute GA) shipped in October 2023 (over 2.5 years ago).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- end }} | ||
| spec: | ||
| parentRefs: | ||
| {{ required "A valid .Values.httpRoute.parentRefs entry is required when httpRoute.enabled is true" .Values.httpRoute.parentRefs | toYaml | indent 4 }} |
There was a problem hiding this comment.
The required message says “.Values.httpRoute.parentRefs entry”, but parentRefs is a list. Consider clarifying the message to indicate a non-empty list / at least one parentRef is required.
| {{ required "A valid .Values.httpRoute.parentRefs entry is required when httpRoute.enabled is true" .Values.httpRoute.parentRefs | toYaml | indent 4 }} | |
| {{ required "A non-empty .Values.httpRoute.parentRefs list with at least one parentRef is required when httpRoute.enabled is true" .Values.httpRoute.parentRefs | toYaml | indent 4 }} |
|
|
|
Thanks, @voriol 👍 |
No description provided.