Revert "Pass through the initial options on creation"#301676
Merged
Conversation
lszomoru
approved these changes
Mar 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the earlier change that forwarded initial session options during chat session creation/initialization, removing the related context plumbing across the proposed API surface and the main thread/ext host bridge.
Changes:
- Removes session-option context from the proposed
ChatSessionContentProvider.provideChatSessionContentsignature and related DTOs. - Removes
initialSessionOptionspropagation from internal new-session request types and the ext host/controller invocation path. - Updates main thread initialization and tests to no longer pass/expect the initial session-options context.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts | Reverts proposed API additions for passing session options during session content resolution. |
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Removes initialSessionOptions from the internal new-session request interface. |
| src/vs/workbench/contrib/chat/common/chatService/chatServiceImpl.ts | Stops including initial session options when creating a new session item for untitled remote sessions. |
| src/vs/workbench/api/test/browser/mainThreadChatSessions.test.ts | Removes test that asserted initial session options were forwarded during initialization. |
| src/vs/workbench/api/common/extHostChatSessions.ts | Removes context DTO usage and stops forwarding initial session options to extensions during session content resolution/new-item handler. |
| src/vs/workbench/api/common/extHost.protocol.ts | Removes the session-content context DTO and updates the $provideChatSessionContent shape signature accordingly. |
| src/vs/workbench/api/browser/mainThreadChatSessions.ts | Updates session initialization to call $provideChatSessionContent without the removed context argument. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #301598
Related: #301677