[0.81] Fix Circular Dependency issues for New Arch Apps#15805
Open
vineethkuttan wants to merge 1 commit intomicrosoft:0.81-stablefrom
Open
[0.81] Fix Circular Dependency issues for New Arch Apps#15805vineethkuttan wants to merge 1 commit intomicrosoft:0.81-stablefrom
vineethkuttan wants to merge 1 commit intomicrosoft:0.81-stablefrom
Conversation
* Try fixing microsoft#13599 * Change files * fix by looking in winget-cli - microsoft/winget-cli#5932 * Make changes in MyApp and revert changes in the prop * Add Force Synchronous PDB Write * Remove the direct Build.0/Deploy.0 entries for the vcxproj * fix folly build issues - reverting playground.yml * Set WinMD generation to true
Contributor
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing Circular Dependency issues for New Arch Apps
Type of Change
Why
Due to ongoing issues in microsoft/cppwinrt#950 , we added a temporary fix in #13338 to make the projects build with -m , i.e one concurrent process for building the RNW App, refer here
What
Inspired by this changes microsoft/winget-cli#5932 , I have defined CppWinRTGenerateWindowsMetadata to prevent the circular reference in calculating the value
Testing
Tested in playground
Changelog
Should this change be included in the release notes: yes
Circular dependency build issues for RNW Fabric App has been fixed
Microsoft Reviewers: Open in CodeFlow