handlematrix: support editing instagram room avatar#219
Open
Conversation
Fizzadar
requested changes
Mar 24, 2026
pkg/messagix/graphql/docs.go
Outdated
|
|
||
| type GraphQLDoc struct { | ||
| DocId string | ||
| ClientDocId string |
Member
There was a problem hiding this comment.
Suggested change
| ClientDocId string | |
| ClientDocID string |
For consistency, plus elsewhere
pkg/messagix/instagram.go
Outdated
| h.Set("image_type", "FILE_ATTACHMENT") | ||
| h.Set("x-entity-name", entityID) | ||
| h.Set("x-entity-length", strconv.Itoa(len(avatar))) | ||
| h.Set("x-entity-type", "image/jpeg") |
Member
There was a problem hiding this comment.
Seems wrong? Although not entirely sure how we pass this from bridge side (@tulir?)
Member
There was a problem hiding this comment.
http.DetectContentType can be used to detect input format from bytes, if IG only allows jpeg then need to convert it with the image package first (image.Decode + jpeg.Encode)
pkg/messagix/instagram.go
Outdated
| h.Set("ig-intended-user-id", strconv.FormatInt(ig.client.cookies.GetUserID(), 10)) | ||
| h.Set("ig-u-ds-user-id", strconv.FormatInt(ig.client.cookies.GetUserID(), 10)) | ||
| h.Set("x-mid", ig.client.cookies.Get(cookies.IGCookieMachineID)) | ||
| h.Set("x-ig-app-id", ig.client.configs.BrowserConfigTable.CurrentUserInitialData.AppID) |
Member
There was a problem hiding this comment.
Should we be using an Android app ID here?
tulir
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.