Conversation
mw-hrastega
reviewed
Mar 25, 2026
| p = gcp("nocreate"); | ||
| if ~isempty(p) | ||
| warning("opentelemetry:buildtool:OpenTelemetryPlugin:NoParallelEmit", ... | ||
| "Tasks run on parallel workers will not emit telemetry data"); |
Member
There was a problem hiding this comment.
A couple of suggestions:
- Let's not use future tense.
- Warnings should end in a period.
Proposed edit:
Tasks executed on parallel workers do not emit telemetry data.
Question: Does a task that runs on a client (e.g., a TestTask instance) emit data?
Member
Author
There was a problem hiding this comment.
Thanks Houman, I like your proposal and will update the message. Tasks that run on the client will indeed emit data.
mw-hrastega
approved these changes
Mar 25, 2026
duncanpo
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel workers currently do not emit telemetry data, and there are a few technical hurdles to implementing that behavior. After some consideration, I've decided that the best approach moving forward is to warn the user of this behavior, but keep it as it is today so that we can still provide users with telemetry data related to the overall build result and all tasks which ran on the client.
Unfortunately, the framework currently does not have a way to determine from within a plugin whether the build is running in parallel or not. As such, I check whether a parpool is open. This approach will never result in false negatives, but may occasionally result in false positives. Because the impact of a false positive is very low here, this seems acceptable to me but I welcome feedback from others on that decision.