Fix exists operator to return true for empty strings and zero times#53
Merged
Fix exists operator to return true for empty strings and zero times#53
Conversation
The exists operator and function incorrectly returned false for empty
strings and zero-valued times because they called Nil() which treats
these as nil. exists should only return false for actual nil/NilValue,
not for valid values like "" or time.Time{}.
Fixes lytics/lio#38265
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
junichif
force-pushed
the
fix/exists-empty-string
branch
from
abea4ed to
1bc01bc
Compare
sumankarki
approved these changes
Mar 20, 2026
ryan-cstk
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exists operator and function incorrectly returned false for empty strings and zero-valued times because they called Nil() which treats these as nil. exists should only return false for actual nil/NilValue, not for valid values like "" or time.Time{}.
Fixes lytics/lio#38265