Conversation
tiurin
left a comment
tiurin
left a comment
There was a problem hiding this comment.
https://github.com/localstack/localstack-toolkit-vscode/blob/main/CONTRIBUTING.md#releasing-a-new-version - this section needs updating. Also, I think it is good to call out that we basically have a continuous delivery now.
Good call. I just amended the docs. |
.github/workflows/release.yml
Outdated
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 8 * * *' # Every day at 08:00 UTC |
There was a problem hiding this comment.
I think everyday including weekend it too much especially since when we're off, maybe once a week is okay for now.
With this refactor, we still have the option to trigger the workflow manually, right?
Also, do we run the tests in this worflow refactor? Would be great make sure all tests pass before pushing the release artifacts 🙏🏼
There was a problem hiding this comment.
Fair enough, changing to once a week.
With the current pipeline, everything in main has passed the tests and thus is safe to publish.
There was a problem hiding this comment.
With the current pipeline, everything in main has passed the tests and thus is safe to publish.
It can happen that a PR can be merged by admins without checks or approval. Having tests rerun for safety wouldn't hurt IMO. Up to you 🙏🏼
There was a problem hiding this comment.
Better safe than sorry, I'll add a test check before that.
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Thanks for adding the test job, LGTM! 📦
3 participants
Refactors the release and publish workflows to schedule a daily release, including automatic version bumping using
npx commit-and-tag-version. The release can also be manually dispatched.Additionally, removes the makefile in favor of in-lining the scripts (less maintenance burden), and updates the docs.
Finally, splits the pull request checks into fine-tuned jobs.