feat: support web console opener, deprecate sandbox creation#821
Open
rektdeckard wants to merge 1 commit intomainfrom
Open
feat: support web console opener, deprecate sandbox creation#821rektdeckard wants to merge 1 commit intomainfrom
rektdeckard wants to merge 1 commit intomainfrom
Conversation
yoonsio
approved these changes
Apr 10, 2026
Contributor
yoonsio
left a comment
There was a problem hiding this comment.
Do we still support template projects?
Member
Author
|
@yoonsio yes, the templates are unchanged except that the agent name is now used to print a link to the web-based console instead of a sandbox (for python and node agent templates):
|
real-danm
approved these changes
Apr 10, 2026
| fmt.Println("Installing template...") | ||
| if err := doInstall(ctx, bootstrap.TaskInstall, appName, verbose); err != nil { | ||
| return err | ||
| fmt.Fprintf(os.Stderr, "Warning: installation failed: %v\n", err) |
Contributor
There was a problem hiding this comment.
Was the intent here to make install failures non fatal? I’m asking because it looks like we continue into post_create and cleanup even if doInstall fails, and I wasn’t sure if that could leave someone with a partially initialized app that’s harder to deal with?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

lk token create,lk room joinlk agent initno longer defaults to creating a sandbox (and the flag is deprecated and hidden)lk agent initandlk app createnow print Web Console link on completionlk agent initandlk app createnow prompt to auto-install dependencies