fix: prioritize reliable thermal sensors over acpitz#192
Open
CoRfr wants to merge 1 commit intoleukipp:developfrom
Open
fix: prioritize reliable thermal sensors over acpitz#192CoRfr wants to merge 1 commit intoleukipp:developfrom
CoRfr wants to merge 1 commit intoleukipp:developfrom
Conversation
acpitz can report invalid temperatures (e.g. -269°C on Surface Pro 3). Prioritize x86_pkg_temp, k10temp, cpu-thermal, soc_dts0, PNIT over acpitz, and filter out values outside the -40°C to 150°C range. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aa3b9ee to
b88add6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x86_pkg_temp,k10temp,cpu-thermal) overacpitzProblem
getProcessorTemperature()returns the first matching thermal zone, which on some hardware (e.g. Surface Pro 3) isacpitzreporting -269°C. Meanwhilex86_pkg_tempon the same device correctly reports ~46°C.Fix
Instead of returning the first match, iterate all zones and select the one with the highest priority.
acpitzis kept as a last-resort fallback but only if its value is within a sane range.🤖 Generated with Claude Code