Fix CreateProcessW failing when :directory is specified on Windows#33
Open
Catsquotl wants to merge 1 commit intolem-project:masterfrom
Open
Fix CreateProcessW failing when :directory is specified on Windows#33Catsquotl wants to merge 1 commit intolem-project:masterfrom
Catsquotl wants to merge 1 commit intolem-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dir-wideforeign string increate-processwas missing the:encoding :utf-16leparameter, whilecmd-widehad it correctly set.Since
CreateProcessWexpects UTF-16LE strings, passing a directorywould always cause the process creation to fail.
This broke
M-x slimein Lem on Windows, which passes the buffer'sdirectory when starting the Lisp subprocess.
Fix: add
:encoding :utf-16leto thedir-wideforeign string allocation.The fix works, for full disclosure, Claude ai did most of the bug hunting and suggested fixes, I just copied and pasted through the process for a few hours