Skip to content

Relocating assets/images/partners to static/partners#7439

Open
Zedoman wants to merge 7 commits intolayer5io:masterfrom
Zedoman:master
Open

Relocating assets/images/partners to static/partners#7439
Zedoman wants to merge 7 commits intolayer5io:masterfrom
Zedoman:master

Conversation

@Zedoman
Copy link

@Zedoman Zedoman commented Feb 23, 2026

Description

This PR fixes #7256 by relocating assets/images/partners to static/partners and updating all references to use absolute static paths.

Notes for Reviewers
No functional changes beyond asset relocation and reference updates.

Signed commits

  • [ X ] Yes, I signed my commits.

@github-actions github-actions bot added area/blog New posts or new blog functionality area/events labels Feb 23, 2026
@Zedoman Zedoman changed the title Offer letter fix and send Relocating assets/images/partners to static/partners Feb 23, 2026
Signed-off-by: Zedoman <avradeep2000@gmail.com>
@l5io
Copy link
Member

l5io commented Feb 23, 2026

🚀 Preview for commit 739c9af at: https://699ca30000611076aa229fc1--layer5.netlify.app

@l5io
Copy link
Member

l5io commented Feb 26, 2026

🚀 Preview for commit fdf8d86 at: https://69a06d612a85d8113cebb211--layer5.netlify.app

@Zedoman
Copy link
Author

Zedoman commented Feb 26, 2026

Hi @Rajesh-Nagarajan-11, Can you please review it once.

@CodexRaunak
Copy link
Contributor

CodexRaunak commented Feb 28, 2026

@Zedoman Since the static directory get's included as it is in the site build, shouldn't it be clean?

@l5io
Copy link
Member

l5io commented Feb 28, 2026

🚀 Preview for commit f745285 at: https://69a2c50276b3d9234715a1e9--layer5.netlify.app

@Zedoman
Copy link
Author

Zedoman commented Feb 28, 2026

@Zedoman Since the static directory get's included as it is in the site build, shouldn't it be clean?

I didnt get the point. Clean means?

@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit e8a633c at: https://69a6f70b35189f12efb71821--layer5.netlify.app

@Bhumikagarggg
Copy link
Contributor

@Zedoman Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Thank you for tackling #7256! Moving partner assets to static/ is the correct Gatsby pattern. However, there's a functional regression that needs to be addressed before this can merge.

🔴 Color-mode SVGs will break

Files with the -colorMode.svg suffix (e.g., citrix-colorMode.svg, cncf-stacked-colorMode.svg, intel-colorMode.svg, oam-colorMode.svg, etc.) rely on inline SVG rendering to support light/dark theming via CSS currentColor or CSS variables. When imported as ReactComponent, they render as inline <svg> elements that CSS can style.

After this PR, they are changed to <img src> references, which load SVGs as external resources — CSS cannot reach into the SVG to change fill/stroke. The color-mode switching will silently break for ~14 partner logos in:

  • src/sections/Home/Proud-maintainers/index.js (CNCF, OAM)
  • src/sections/Partners/partners.js (Citrix, CNCF-stacked, HashiCorp, HPE, Istio, Microsoft, RedHat, Intel, VMware, Metabit, Docker, DigitalOcean)

These -colorMode.svg files should remain as ReactComponent imports (kept in src/assets/ or re-imported inline), or the theming approach needs to change.

🟡 Minor: StaticImage → img loses Gatsby image optimization

In Careers-Internship-grid/index.js, StaticImage is replaced with plain <img> for the university partner logos. StaticImage provides lazy loading, WebP conversion, and blur-up placeholders. This is a minor regression, though using StaticImage with variables was already technically invalid (Gatsby requires string literals for src).

✅ What's good

  • Moving to static/partners/ is the right approach for Gatsby public assets
  • The LazyPartnerImage guard (typeof partner.imageLink === "function") correctly handles the mixed-type imageLink values
  • MDX path and export const changes are correct
  • GraphQL formatting cleanup is a nice improvement

Please fix the -colorMode.svg inline SVG issue and this will be in good shape to merge.

@saurabhraghuvanshii
Copy link
Member

hi @Zedoman Please address above comment^^

@Zedoman
Copy link
Author

Zedoman commented Mar 10, 2026

Hello @saurabhraghuvanshii ,

Sure. Apologies for the delay — I assumed the task had been rejected since there hadn’t been any review updates. Thank you for the response.

@leecalcote , I will update it as soon as possible.

@l5io
Copy link
Member

l5io commented Mar 11, 2026

🚀 Preview for commit 6117e5e at: https://69b18a4b10071605390acf5c--layer5.netlify.app

@Zedoman
Copy link
Author

Zedoman commented Mar 11, 2026

@saurabhraghuvanshii @leecalcote Sir You can check now once.

@saurabhraghuvanshii
Copy link
Member

Looking ....

@saurabhraghuvanshii
Copy link
Member

@Zedoman I think images should be move to /static/images/partners not directly to /static/partners

and Please resolve merge conflicts.

@Zedoman
Copy link
Author

Zedoman commented Mar 13, 2026

Ok sure.

@Zedoman
Copy link
Author

Zedoman commented Mar 14, 2026

Ok sir. I will update once its done.

…ly to /static/partners

Signed-off-by: Zedoman <avradeep2000@gmail.com>
@Zedoman
Copy link
Author

Zedoman commented Mar 14, 2026

@saurabhraghuvanshii I have fixed the changes but for the conflict I couldnt see in my local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/blog New posts or new blog functionality area/events

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relocate partner logos to appropriate directory in static folder.

7 participants