DO NOT MERGE: Test PR to debug cel condition tests by liamfallon · Pull Request #4472 · kptdev/kpt

liamfallon · 2026-04-09T05:40:10Z

Duplicate PR of #4469, raised to debug the CEL tests on the PR

Signed-off-by: liamfallon <liam.fallon@est.tech>

netlify · 2026-04-09T05:40:16Z

✅ Deploy Preview for kptdocs ready!

Name	Link
🔨 Latest commit	`91c36e2`
🔍 Latest deploy log	https://app.netlify.com/projects/kptdocs/deploys/69d73e56e22d870008f96e16
😎 Deploy Preview	https://deploy-preview-4472--kptdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Adds CEL-based conditional execution for kpt functions and extends results/status reporting so skipped functions are reflected in CLI output and pipeline status, along with unit/E2E coverage.

Changes:

Introduces a shared CEL environment (RunnerOptions.CELEnvironment) and condition evaluation logic to skip function execution when a CEL expression evaluates to false.
Propagates condition through Kptfile schema/types, CLI (fn eval --condition), and status/result types via a skipped flag.
Adds unit tests and E2E golden testdata for condition-met / condition-not-met scenarios; adjusts a couple of E2E timeouts.

Reviewed changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
thirdparty/kyaml/runfn/runfn.go	Adds `Condition` to `RunFns` and wires it into the function runner.
thirdparty/cmdconfig/commands/cmdeval/cmdeval.go	Adds `--condition` flag and passes condition through to `runfn.RunFns` / Kptfile function object.
thirdparty/cmdconfig/commands/cmdeval/cmdeval_test.go	Updates eval runner tests for new runner options field.
pkg/lib/runneroptions/runneroptions.go	Adds `CELEnvironment` to `RunnerOptions` and `InitCELEnvironment()` initializer.
pkg/lib/runneroptions/celenv.go	Implements CEL environment creation + condition evaluation against KRM resources.
pkg/lib/kptops/render_test.go	Initializes CEL environment in render tests.
pkg/lib/kptops/fs_test.go	Initializes CEL environment in fs-based render tests.
pkg/api/kptfile/v1/types.go	Adds `Function.Condition` and `PipelineStepResult.Skipped`.
pkg/api/fnresult/v1/types.go	Adds `Result.Skipped` to structured function results.
internal/util/render/executor.go	Avoids counting skipped functions as “executed”; surfaces skipped in step capture.
internal/util/get/get.go	Initializes CEL environment for hook execution path.
internal/fnruntime/runner.go	Evaluates conditions pre-exec, emits `[SKIPPED]`, and records skipped results.
internal/fnruntime/condition_test.go	Adds unit tests for conditional execution across runtimes.
internal/fnruntime/celeval_test.go	Adds unit tests for CEL environment + evaluation behavior.
go.mod	Adds CEL-related dependencies (`cel-go`, `k8s.io/apiserver` CEL libs, etc.).
go.sum	Adds checksums for new dependencies.
e2e/testdata/live-apply/json-output/config.yaml	Increases reconcile timeout used by test scenario.
e2e/testdata/live-apply/apply-depends-on/config.yaml	Increases reconcile timeout used by test scenario.
e2e/testdata/fn-render/condition/condition-not-met/resources.yaml	Adds E2E inputs for “condition not met” case.
e2e/testdata/fn-render/condition/condition-not-met/Kptfile	Adds pipeline with a `condition` expression.
e2e/testdata/fn-render/condition/condition-not-met/.krmignore	Ignores `.expected` for the new test package.
e2e/testdata/fn-render/condition/condition-not-met/.expected/diff.patch	Expected diff showing condition persistence + skipped status.
e2e/testdata/fn-render/condition/condition-not-met/.expected/config.yaml	Expected stderr output including `[SKIPPED]` and 0 executed functions.
e2e/testdata/fn-render/condition/condition-met/resources.yaml	Adds E2E inputs for “condition met” case.
e2e/testdata/fn-render/condition/condition-met/Kptfile	Adds pipeline with a `condition` expression.
e2e/testdata/fn-render/condition/condition-met/.krmignore	Ignores `.expected` for the new test package.
e2e/testdata/fn-render/condition/condition-met/.expected/diff.patch	Expected diff for the “condition met” path.
e2e/testdata/fn-render/condition/condition-met/.expected/config.yaml	Expected stderr output for normal execution.
documentation/content/en/reference/schema/kptfile/kptfile.yaml	Updates schema reference to include `condition`.
documentation/content/en/book/04-using-functions/_index.md	Documents `condition` usage and adds examples.
documentation/content/en/book/01-getting-started/_index.md	Minor wording fixes in getting started guide.
commands/fn/render/cmdrender.go	Initializes CEL environment for `kpt fn render`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-09T05:44:52Z

thirdparty/kyaml/runfn/runfn.go

+	runner, _ := fnruntime.NewFunctionRunner(r.Ctx, fltr, "", fnResult, r.fnResults, opts)
+	if r.Condition != "" {
+		runner.SetCondition(r.Condition, opts.CELEnvironment)
+	}
+	return runner, nil


NewFunctionRunner returns an error but it’s being discarded (runner, _ := ...). Handle/propagate the error before using runner.

Also, when r.Condition is set but opts.CELEnvironment is nil, SetCondition will silently disable condition evaluation (because Filter checks fr.celEnv != nil). Consider returning an error when a condition is provided without a CEL environment (consistent with fnruntime.NewRunner).

Copilot · 2026-04-09T05:44:52Z

commands/fn/render/cmdrender.go

 func (r *Runner) InitDefaults() {
 	r.RunnerOptions.InitDefaults(runneroptions.GHCRImagePrefix)
+	// Initialize CEL environment for condition evaluation
+	// Ignore error as conditions are optional; if CEL init fails, conditions will error at runtime
+	_ = r.RunnerOptions.InitCELEnvironment()
 }


InitDefaults ignores the InitCELEnvironment() error, but conditions in Kptfiles will fail later if RunnerOptions.CELEnvironment is nil (see fnruntime.NewRunner). Either propagate the init error here or adjust the surrounding logic/comments so a CEL init failure can’t lead to confusing runtime behavior.

Copilot · 2026-04-09T05:44:52Z

thirdparty/cmdconfig/commands/cmdeval/cmdeval.go

 func (r *EvalFnRunner) InitDefaults() {
 	r.RunnerOptions.InitDefaults(runneroptions.GHCRImagePrefix)
+	// Initialize CEL environment for condition evaluation
+	// Ignore error as conditions are optional; if CEL init fails, conditions will error at runtime
+	_ = r.RunnerOptions.InitCELEnvironment()
 }


InitDefaults ignores the InitCELEnvironment() error. With --condition set, a nil CEL environment will cause the condition to be skipped (runfn path) or error later (fnruntime path). Please handle the error (return/print) so conditions can’t be silently ignored.

Copilot · 2026-04-09T05:44:53Z

pkg/lib/runneroptions/runneroptions.go

 	ResolveToImage ImageResolveFunc
+
+	// CELEnvironment is the shared CEL environment used to evaluate function conditions.
+	// It is initialised by InitDefaults and reused across all function runners.


The comment says CELEnvironment is initialized by InitDefaults, but initialization is now done by InitCELEnvironment().

Please update this comment to reflect the actual initialization flow (and avoid implying it’s always non-nil after InitDefaults).

Suggested change

// It is initialised by InitDefaults and reused across all function runners.

// It is initialized by InitCELEnvironment and reused across all function runners.

// It may be nil until InitCELEnvironment has been called successfully.

Copilot · 2026-04-09T05:44:53Z

documentation/content/en/book/04-using-functions/_index.md

+
+The expression receives a variable called `resources`, which is a list of all KRM resources passed to
+this function step (after `selectors` and `exclude` have been applied). Each resource is a map with
+the standard fields: `apiVersion`, `kind`, `metadata`, `spec`, `status`.


The docs say each resources entry has standard fields apiVersion, kind, metadata, spec, status, but the implementation only guarantees defaults for apiVersion, kind, and metadata (see resourceToMap in pkg/lib/runneroptions/celenv.go). Either update the docs to clarify that spec/status may be absent or update the conversion to default those keys as well.

Suggested change

the standard fields: `apiVersion`, `kind`, `metadata`, `spec`, `status`.

the standard fields `apiVersion`, `kind`, and `metadata`. Depending on the resource, fields such as

`spec` and `status` may also be present.

Copilot · 2026-04-09T05:44:53Z

documentation/content/en/book/04-using-functions/_index.md

+
+[SKIPPED] "ghcr.io/kptdev/krm-functions-catalog/set-labels:latest" (condition not met)
+
+Successfully executed 1 function(s) in 1 package(s).


In the “condition not met” example, the output says Successfully executed 1 function(s) even though skipped functions are not counted as executed (and the e2e expectations show 0 function(s)). Please update the example output to match the CLI behavior.

Suggested change

Successfully executed 1 function(s) in 1 package(s).

Successfully executed 0 function(s) in 1 package(s).

Copilot · 2026-04-09T05:44:53Z

internal/util/get/get.go

+		// Initialize CEL environment for condition evaluation
+		// Ignore error as conditions are optional; if CEL init fails, conditions will error at runtime
+		_ = hookCmd.RunnerOptions.InitCELEnvironment()


InitCELEnvironment() errors are ignored here, but later code paths require RunnerOptions.CELEnvironment to evaluate conditions. Please handle/propagate this error (or intentionally disable condition support in this flow with an explicit message) to avoid silent misbehavior.

Suggested change

// Initialize CEL environment for condition evaluation

// Ignore error as conditions are optional; if CEL init fails, conditions will error at runtime

_ = hookCmd.RunnerOptions.InitCELEnvironment()

// Initialize CEL environment for condition evaluation.

// Fail early if initialization does not succeed because hook execution

// may require CEL to evaluate conditions.

if err := hookCmd.RunnerOptions.InitCELEnvironment(); err != nil {

return fmt.Errorf("initializing CEL environment for deployment hooks: %w", err)

}

Signed-off-by: liamfallon <liam.fallon@est.tech>

liamfallon · 2026-04-09T10:25:23Z

Closed because tests are passing on PR #4469 now

liamfallon added 2 commits April 9, 2026 06:32

Fixing condition test

65b05c7

Signed-off-by: liamfallon <liam.fallon@est.tech>

Fix up tests

d71f119

Signed-off-by: liamfallon <liam.fallon@est.tech>

Copilot AI review requested due to automatic review settings April 9, 2026 05:40

liamfallon requested review from efiacor, kispaljr and mozesl-nokia as code owners April 9, 2026 05:40

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. do-not-merge-work-in-progress Work in progress, do not merge Testing labels Apr 9, 2026

Copilot started reviewing on behalf of liamfallon April 9, 2026 05:40 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Tweak expected output

91c36e2

Signed-off-by: liamfallon <liam.fallon@est.tech>

liamfallon mentioned this pull request Apr 9, 2026

feat: Add CEL-based conditional function execution (#4388) #4469

Open

liamfallon closed this Apr 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE: Test PR to debug cel condition tests#4472

DO NOT MERGE: Test PR to debug cel condition tests#4472
liamfallon wants to merge 3 commits intokptdev:mainfrom
Nordix:cel-tests

liamfallon commented Apr 9, 2026

Uh oh!

netlify bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

Copilot AI Apr 9, 2026

Uh oh!

liamfallon commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// It is initialised by InitDefaults and reused across all function runners.
	// It is initialized by InitCELEnvironment and reused across all function runners.
	// It may be nil until InitCELEnvironment has been called successfully.

	the standard fields: `apiVersion`, `kind`, `metadata`, `spec`, `status`.
	the standard fields `apiVersion`, `kind`, and `metadata`. Depending on the resource, fields such as
	`spec` and `status` may also be present.


		[SKIPPED] "ghcr.io/kptdev/krm-functions-catalog/set-labels:latest" (condition not met)

		Successfully executed 1 function(s) in 1 package(s).

	Successfully executed 1 function(s) in 1 package(s).
	Successfully executed 0 function(s) in 1 package(s).

-		// Initialize CEL environment for condition evaluation
-		// Ignore error as conditions are optional; if CEL init fails, conditions will error at runtime
-		_ = hookCmd.RunnerOptions.InitCELEnvironment()
+		// Initialize CEL environment for condition evaluation.
+		// Fail early if initialization does not succeed because hook execution
+		// may require CEL to evaluate conditions.
+		if err := hookCmd.RunnerOptions.InitCELEnvironment(); err != nil {
+			return fmt.Errorf("initializing CEL environment for deployment hooks: %w", err)
+		}

Conversation

liamfallon commented Apr 9, 2026

Uh oh!

netlify bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kptdocs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

liamfallon commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Apr 9, 2026 •

edited

Loading