Skip to content

build: Implement semantic versioning in build system #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NETIZEN-11 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

build: Implement semantic versioning in build system #4468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,23 @@ YEAR_GEN := $(shell date '+%Y')

GOBIN := $(shell go env GOPATH)/bin
GIT_COMMIT := $(shell git rev-parse --short HEAD)
GIT_TAG := $(shell git describe --tags --exact-match 2>/dev/null)
DIRTY := $(shell git status --porcelain)

# Version logic:
# - Use tag ONLY if exact match AND clean working tree
# - Otherwise fallback to dev version
ifeq ($(GIT_TAG),)
VERSION := v0.0.0-dev+$(GIT_COMMIT)
else ifneq ($(DIRTY),)
VERSION := v0.0.0-dev+$(GIT_COMMIT)
else
VERSION := $(GIT_TAG)
endif

export KPT_FN_WASM_RUNTIME ?= nodejs

LDFLAGS := -ldflags "-X github.com/kptdev/kpt/run.version=${GIT_COMMIT}
LDFLAGS := -ldflags "-X github.com/kptdev/kpt/run.version=${VERSION}
ifeq ($(OS),Windows_NT)
# Do nothing
else
Expand Down