Allow assignment and preview links to work in Jupyterhub environment outside iframe#1983
Open
xcompass wants to merge 1 commit intojupyter:mainfrom
Open
Allow assignment and preview links to work in Jupyterhub environment outside iframe#1983xcompass wants to merge 1 commit intojupyter:mainfrom
xcompass wants to merge 1 commit intojupyter:mainfrom
Conversation
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the generated links for assignment and preview are missing base_url when nbgrader is running under Jupyterhub and outside of iframe (e.g. new tab). The generated links are something like
https://jupyter.example.com/tree/source/assignment1instead ofhttps://jupyter.exmple.com/jupyter/user/username/tree/source/assignment1, missing thebase_url(/jupyter/user/username/) part.This PR is to fix this issue and allow nbgrader to run under Jupyterhub as a separate tab/window. (this is for the use case where Jupyterhub instances that don't have subdomain enabled)
This PR doesn't affect the use cases for nbgrader running in Jupter notebook or lab. As in both cases, base_url are empty ("") and the flow goes to
elsebranch in thelinkTofunction