Incorporate the qFSP mask into InSAR mask#247
Open
xhuang-jpl wants to merge 38 commits intoisce-framework:developfrom
Open
Incorporate the qFSP mask into InSAR mask#247xhuang-jpl wants to merge 38 commits intoisce-framework:developfrom
xhuang-jpl wants to merge 38 commits intoisce-framework:developfrom
Conversation
added 30 commits
September 19, 2023 20:40
xhuang-jpl
changed the title
xhuang-jpl
requested review from
Tyler-g-hudson,
hfattahi,
oberonia78 and
seongsujeong
Contributor
|
We reviewed this PR in a PR review session. Overall it looks good pending testing and very minor comments provided offline. |
xhuang-jpl
commented
Apr 8, 2026
Comment on lines
+591
to
+592
| sec_i = int(int(i) + azimuth_off[0,int(j)] + 0.5) | ||
| sec_j = int(int(j) + range_off[0,int(j)] + 0.5) |
Contributor
Author
There was a problem hiding this comment.
Use round() function here
| # The azimuth index is not in the radar grid meaning no subswath mask | ||
| else: | ||
| subswath_mask += [0] * len(rg_idx_arr) | ||
| mask += [0] * len(rg_idx_arr) |
Contributor
Author
There was a problem hiding this comment.
may use the fillvalue (255) here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to incorporate the qFSP mask into the InSAR mask, where many places are updated including:
geocode_insar.pyinterpret_subswath_maskfunction