Add an optional retry delay

[beryllium]

By specifying an optional 3rd parameter (in seconds), you can cause a small delay between retries. This can be useful to avoid the perception of flooding.

[igorw]

I'm inclined to keep this lib as simple and small as possible. I am however considering adding a delay, or even a generic onError mechanism.

[Seldaek]

+1 for usleep. Some things fix themselves rather quickly :) Third param could accept int microseconds for delay or a callable for custom onError?

[jmikola]

Third param could accept int microseconds for delay or a callable for custom onError?

👍 for keeping this flexible. While the general case will be for a fixed delay, there are cases where you might want to implement an exponential backoff (e.g. doctrine/mongodb#120 (comment)) or some other logic.

[beryllium]

Yeah, I like the callable idea. Not sure about calling it onError, though - maybe onRetry?

[igorw]

Here's my WIP proposal btw https://github.com/igorw/retry/compare/on-error

[yitznewton]

@beryllium or maybe, beforeRetry

[jmikola]

@igorw: Whipped up the following, which I think would work nicely with the $onError callback:

<?php

class ExponentialBackoff
{
    private $invoked = 0;
    private $slotTimeUsec;

    public function __construct($slotTimeUsec)
    {
        $this->slotTimeUsec = (int) $slotTimeUsec;
    }

    public function __invoke()
    {
        usleep(rand(0, (2 << (++$this->invoked - 1)) - 1) * $this->slotTimeUsec);
    }
}

Missing bounds detection for the bit-shifting (probably to cap it at PHP_INT_MAX), but it implements the general formula from http://en.wikipedia.org/wiki/Exponential_backoff.