feat(dips): log proposal rejections at INFO level#968
Open
MoonBoi9001 wants to merge 2 commits intomain-dipsfrom
Open
feat(dips): log proposal rejections at INFO level#968MoonBoi9001 wants to merge 2 commits intomain-dipsfrom
MoonBoi9001 wants to merge 2 commits intomain-dipsfrom
Conversation
When an RCA proposal is rejected, log the rejection reason, error, and deployment ID (when decodable) at INFO level. Previously the rejection was returned via the gRPC response with no server-side log at INFO, making debugging difficult without access to the client. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MoonBoi9001
force-pushed
the
feat/dips-rejection-logging
branch
from
02746b3 to
63c0c2a
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When indexer-service rejects a DIPs agreement proposal, the rejection reason was only returned in the gRPC response with no server-side log at INFO level. Diagnosing why proposals were being rejected required checking the client (Dipper) side, which isn't always practical.
Summary
try_extract_deployment_idhelper that does best-effort ABI decoding of the signed voucher bytes to extract the subgraph deployment IDExample log output: