Conversation
Added an optional `--use-keyring` flag to the `login` command to store credentials securely in the system keyring. Implemented two new commands, `import-credentials` and `export-credentials` to migrate existing file-based credentials into the system keyring, or export them back. Re-routing reads and writes correctly defaults to the KeyringCredentialStore when valid credentials exist in the system keyring for the user, while still supporting the legacy `.clasprc.json` system by default. Co-authored-by: sqrrrl <346343+sqrrrl@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added an optional `--use-keyring` global flag to store and retrieve credentials securely in the system keyring. Implemented two new commands, `import-credentials` and `export-credentials` to migrate all existing file-based credentials into the system keyring, or export them back. To avoid unnecessary system keyring permission prompts, an `is_keyring` stub is saved to the file store (`.clasprc.json`). This ensures that the `KeyringCredentialStore` is only accessed if the user has opted in. Co-authored-by: sqrrrl <346343+sqrrrl@users.noreply.github.com>
1 participant
Implemented cross-platform keyring support for
@google/claspas requested, with--use-keyringoption for login, and new migration commands (import-credentials,export-credentials). Tested and verified.PR created automatically by Jules for task 18105576687279207261 started by @sqrrrl