feat: implement PKCE support in OAuth flows#1142
Conversation
- Implemented PKCE support in `AuthorizationCodeFlow` class inside `src/auth/auth_code_flow.ts` by using `generateCodeVerifierAsync` to generate the code verifier and code challenge. - Passed `code_challenge` and `code_challenge_method` (`'S256'`) into `generateAuthUrl` and then passed the `codeVerifier` into `getToken`. - Added unit tests to `test/auth/auth_code_flow.ts` to ensure PKCE is not regressed and both methods receive the correct parameters. Co-authored-by: sqrrrl <346343+sqrrrl@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Added PKCE support to the CLI oauth flows. The CLI acts as a public client and cannot store static secrets. This adds security to the authorization flow. PKCE generation and challenges are now passed into google-auth-library's
generateAuthUrlandgetToken. Tests are also included to verify that these parameters are properly injected.PR created automatically by Jules for task 11585658497447503235 started by @sqrrrl