Refactor: rename contact samples to custom-components-example#1019
Refactor: rename contact samples to custom-components-example#1019
Conversation
There was a problem hiding this comment.
Code Review
This pull request renames the "contact" and "contact_multiple_surfaces" sample to "custom-components-example" across the agent and client codebases, updating documentation, workspace configurations, and test paths. The review feedback identifies several remaining inconsistencies where the old naming or descriptions are still present, specifically within the test catalog configurations, the Python package name in the lock file (which requires a change in pyproject.toml), and the npm package description.
| "path": SAMPLES_DIR / "custom-components-example", | ||
| "catalogs": [ | ||
| CatalogConfig.from_path( | ||
| name="contact_multiple_surfaces_inline_catalog", |
There was a problem hiding this comment.
For consistency with the renaming of the sample from contact_multiple_surfaces to custom-components-example, the name of this CatalogConfig should also be updated. This will improve clarity and maintainability of the tests.
| name="contact_multiple_surfaces_inline_catalog", | |
| name="custom-components-example_inline_catalog", |
samples/agent/adk/uv.lock
Outdated
| @@ -91,7 +91,7 @@ requires-dist = [ | |||
| [[package]] | |||
| name = "a2ui-contact-multiple-surfaces" | |||
There was a problem hiding this comment.
The package name here is inconsistent with the directory rename to custom-components-example. The package name should be updated to a2ui-custom-components-example in the corresponding pyproject.toml file to maintain consistency across the project. After updating pyproject.toml, this lock file should be regenerated.
name = "a2ui-custom-components-example"
| "name": "@a2ui/custom-components-example", | ||
| "private": true, | ||
| "version": "0.8.1", | ||
| "description": "A2UI Contact Demo", |
There was a problem hiding this comment.
Description
Renamed the agent and the client to something clearer. Will have a separate MCP apps only sample.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.