Fix a bug in restaurant_finder sample#1016
Open
slilichenko wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
Incorrect inputAction attribute is used to get the name of the action.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the agent_executor.py file to extract the action name from the name field instead of actionName within the UI event processing logic. The review feedback correctly identifies that this change lacks accompanying unit tests, which is a requirement specified in the repository's style guide to ensure code quality and prevent regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect inputAction attribute is used to get the name of the action.