Use new generic signals across web core#1009
Draft
ava-cassiopeia wants to merge 3 commits intoavac-generic-signalsfrom
Draft
Use new generic signals across web core#1009ava-cassiopeia wants to merge 3 commits intoavac-generic-signalsfrom
ava-cassiopeia wants to merge 3 commits intoavac-generic-signalsfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a pluggable signal abstraction via the FrameworkSignal interface, refactoring the state and rendering layers to support multiple reactive frameworks through a generic signal kind parameter. Feedback indicates that the removal of explicit batching in DataModel could lead to performance issues and recommends adding a batch method to the new abstraction. Furthermore, a misleading comment in DataContext concerning the reactivity of function arguments should be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that I've got these generic signals in a good place (see #1008), this PR actually uses them across web core.
Note: this is a breaking change for any downstream implementations, I don't expect them to compile once they pull this in. But, we have version pinning as-of #996, so we can make that upgrade incrementally. It does mean we'll probably want to publish web core before upgrading those libraries.