Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ic schema Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review min-integrity implementation for GitHub tool
fix: correct write-sink secrecy level for Mar 13, 2026
repos="public" and add guard-policies to stdio schema
Contributor
|
@copilot add to smoke-copilot |
…opilot Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in ee9c867. Added
|
Copilot
AI
changed the title
fix: correct write-sink secrecy level for
fix: correct write-sink secrecy level for Mar 13, 2026
repos="public" and add guard-policies to stdio schemarepos="public", add guard-policies to stdio schema, and smoke-test guard policy
Contributor
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Contributor
Smoke Test Results — Run §23033417149
Overall: PARTIAL (15 ✅, 2
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
|
Review this error message:
Update compiler |
…id bare wildcard scope) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Fixed in 4b900f8. For Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
fix: correct write-sink secrecy level for
fix: don't derive write-sink guard-policy for Mar 13, 2026
repos="public", add guard-policies to stdio schema, and smoke-test guard policyrepos="public"/"all", add guard-policies to stdio schema, and smoke-test guard policy
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the
repos/secrecy/min-integrityguard policy implementation for the GitHub tool, plus a smoke test to exercise the new guard policy feature.Issues
Invalid write-sink pattern for global
reposkeywords:repos="public"producedaccept: ["private:*"](and after an intermediate fix,accept: ["public:*"]) in the derived safe-outputs write-sink policy. However, the safeoutputs server requires owner-scoped patterns like"public:owner/*"or"public:owner/repo"— bare wildcards without an owner component are not valid scopes. The global string keywords"all"and"public"cannot be expressed as owner-scoped patterns, so no write-sink guard-policy should be derived for them.Schema gap:
stdioServerConfigin the public MCP gateway schema (docs/public/schemas/mcp-gateway-config.schema.json) hadadditionalProperties: falsebut noguard-policiesproperty, despite the compiler emitting it for local (Docker) mode.httpServerConfigalready had the field.Changes
mcp_github_config.go: FixderiveSafeOutputsGuardPolicyFromGitHubso that:repos="public"orrepos="all"→ no write-sink guard-policy derived (global keywords cannot be expressed as owner-scoped patterns; consistent with docs: "If you userepos: allorrepos: public, no safeoutputs guard-policy is derived")accept: ["private:owner/repo", "private:owner/*", ...](owner-scoped, unchanged)"owner/repo") →accept: ["private:owner/repo"](owner-scoped, unchanged)docs/public/schemas/mcp-gateway-config.schema.json: Addguard-policiestostdioServerConfigproperties, consistent withhttpServerConfig.safeoutputs_guard_policy_test.go: Update expected values —repos="public"andrepos="all"now expectnil(no policy derived)..github/workflows/smoke-copilot.md: Addrepos: publicandmin-integrity: approvedguard policy to the smoke-copilot workflow to exercise the feature end-to-end.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
✨ PR Review Safe Output Test - Run 23033417149