Support ij_kotlin_indent_size in editorconfig#604
Closed
Goooler wants to merge 1 commit intofacebook:mainfrom
Closed
Support ij_kotlin_indent_size in editorconfig#604Goooler wants to merge 1 commit intofacebook:mainfrom
ij_kotlin_indent_size in editorconfig#604Goooler wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
Author
|
Follow up #570. |
meta-cla
bot
added
the
CLA Signed
Goooler
force-pushed
the
support-ij-kotlin-indent-size
branch
2 times, most recently
from
67a3413 to
6886a26
Compare
hick209
approved these changes
Mar 17, 2026
Contributor
hick209
left a comment
hick209
left a comment
There was a problem hiding this comment.
Oh, dang it! I'm sorry that I ended up missing this one, else it would have made into the most recent release (0.62 from today).
I must have cleared it up from my notifications thinking it was similar to the previous PR.
Changes look good, but need to be rebased before I can pull them in.
`ij_kotlin_indent_size` is an IntelliJ-specific Kotlin language override for `indent_size`, but ktfmt ignored it entirely. Users who configure indentation via `ij_kotlin_indent_size` saw no effect on ktfmt formatting.
## Changes
- **`EditorConfigResolver`**: Register `ij_kotlin_indent_size` as a recognized property and use it as the highest-priority source for `blockIndent`, falling back to `indent_size` → `tab_width` as before:
```
ij_kotlin_indent_size (new, highest priority)
→ indent_size
→ tab_width (when indent_size = tab)
```
- **`EditorConfigResolverTest`**: Two new tests — `ij_kotlin_indent_size` sets `blockIndent`, and takes priority over `indent_size` when both are present.
- **`docs/editorconfig/`**: Added `ij_kotlin_indent_size` to all three example `.editorconfig` files alongside the existing `indent_size`.
Goooler
force-pushed
the
support-ij-kotlin-indent-size
branch
from
6886a26 to
3c2c4dd
Compare
hick209
approved these changes
Mar 19, 2026
cortinico
approved these changes
Mar 20, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ij_kotlin_indent_sizeis an IntelliJ-specific Kotlin language override forindent_size, but ktfmt ignored it entirely. Users who configure indentation viaij_kotlin_indent_sizesaw no effect on ktfmt formatting.Changes
EditorConfigResolver: Registerij_kotlin_indent_sizeas a recognized property and use it as the highest-priority source forblockIndent, falling back toindent_size→tab_widthas before:EditorConfigResolverTest: Two new tests —ij_kotlin_indent_sizesetsblockIndent, and takes priority overindent_sizewhen both are present.docs/editorconfig/: Addedij_kotlin_indent_sizeto all three example.editorconfigfiles alongside the existingindent_size.