Conversation
* Suspend/resume has never worked on Windows (the OS lacks the relevant functionality). Normally Ctrl-Z means EOF in Windows, which ends the program. * Listen for SIGCONT to detect resumption * Move platform-specific code to internal/platform
This is supposed to make the search list move backwards, but it didn't work in my testing. Regardless, we want to handle this now that Terminal will emit MetaShiftTab, to prevent it from ending up in the rune buffer.
This was referenced Mar 29, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @wader @tpodowd
This does a lot of things:
(*Operation).ioloop: instead(*Operation).Runes()makes an ordinary function call into the functionality formerly provided by ioloop(*Terminal).ioloopso thatKickReadno longer needs to be public(*Instance).Readlinewill be able to take acontext.Contextargument to provide timeouts