Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 055fa33295
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| case "$TARGET_ENVIRONMENT" in | ||
| foxtrot) | ||
| E2B_DOMAIN="e2b.dev" |
There was a problem hiding this comment.
Keep foxtrot domain configurable via repository variable
This hardcodes the foxtrot target to e2b.dev, which changes behavior from the previous workflow that read vars.E2B_DOMAIN and can now diverge from the main release pipeline (which still uses vars.E2B_DOMAIN in .github/workflows/release.yml line 268). In repositories where E2B_DOMAIN is intentionally overridden (for example, a non-default/proxied production endpoint), manual foxtrot builds will publish against the wrong domain.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
There was a problem hiding this comment.
nice way to make it easier to build the template for different envs. added the missing fast fail on the domain from the comment.
- this does drop the concurrent build lock on releases but can just rebuild as well. (so if pushing a bunch of changes to code intepreter while also trying to manually rebuild, but the point of the manual rebuild is like... we updated envd but not code interpreter)

This updates the manual prod build workflow to let operators choose foxtrot, staging, or juliett at dispatch time. The workflow resolves the matching E2B domain and API key secret, writes them to GITHUB_ENV, and fails fast on missing or unknown targets. Foxtrot remains the default and the automatic main release workflow stays unchanged. Staging and juliett require the new repository secrets E2B_STAGING_API_KEY and E2B_JULIETT_API_KEY.
Note
Medium Risk
Updates a manually-triggered production build workflow to dynamically select domains and API keys based on operator input, which can affect where templates are built/published. Risk is mainly from misconfiguration of new secrets/inputs causing failed builds or targeting the wrong environment.
Overview
Adds a
target_environmentchoice input to the manualBuild Prod Templateworkflow and includes it in the concurrency group to avoid cross-environment lock contention.The workflow now resolves
E2B_DOMAINandE2B_API_KEYat runtime based on the selected target (foxtrot/staging/juliett), masks the key, writes both toGITHUB_ENV, and fails fast for unknown targets or missing configuration before runningbuild_prod.py.Written by Cursor Bugbot for commit 33d3314. This will update automatically on new commits. Configure here.