Revert "Trim docs using pwsh via dotnet tool to support cross-platform local development."

[mdaigle]

Reverts #4121

[Copilot]

Pull request overview

This PR reverts #4121 by removing the repository-local pwsh dotnet tool usage for doc trimming and returning to invoking system PowerShell (powershell.exe on Windows, pwsh elsewhere) during reference-assembly doc generation.

Changes:

• Replaces dotnet tool run pwsh + dotnet tool restore usage with direct powershell.exe/pwsh invocations.
• Removes the RestoreTools target dependency from the ref csproj’s TrimDocs step.
• Drops the powershell entry from dotnet-tools.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tools/targets/TrimDocsForIntelliSense.targets	Reverts doc-trimming execution to call system PowerShell instead of dotnet tool pwsh.
src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj	Removes tool-restore dependency and builds a PowerShell command using system powershell.exe/pwsh.
dotnet-tools.json	Removes the powershell dotnet tool registration.

Comments suppressed due to low confidence (1)

src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj:58

• -Command "$(RepoRoot)tools\\intellisense\\TrimDocs.ps1 ..." does not quote/invoke the script path. Repos checked out under a path containing spaces can cause PowerShell to parse the script path incorrectly and fail the build. Prefer -File (with a quoted script path) or -Command with & and a quoted script path.

      <PowerShellCommand>
        $(PowerShellCommand)
          -NonInteractive
          -ExecutionPolicy Unrestricted
          -Command "$(RepoRoot)tools\intellisense\TrimDocs.ps1 -inputFile '$(DocumentationFile)' -outputFile '$(DocumentationFile)'"
      </PowerShellCommand>

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.52%. Comparing base (60d4b92) to head (047d3f9).
⚠️ Report is 14 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (60d4b92) and HEAD (047d3f9). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (60d4b92)	HEAD (047d3f9)
CI-SqlClient	1	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4127      +/-   ##
==========================================
- Coverage   73.22%   66.52%   -6.71%     
==========================================
  Files         280      274       -6     
  Lines       43000    65781   +22781     
==========================================
+ Hits        31486    43758   +12272     
- Misses      11514    22023   +10509     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	66.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.