Fix absolute symlinks in PHP artifact bundled libs#99
Open
Conversation
cp -a preserves symlinks verbatim. On some cflinuxfs4 build hosts, /usr/lib/x86_64-linux-gnu/libgpg-error.so is an absolute symlink pointing to /lib/x86_64-linux-gnu/libgpg-error.so.0. libbuildpack rejects absolute symlinks during extraction as a security measure, causing PHP staging to fail with: **ERROR** Could not install PHP: cannot link to an absolute path when extracting archives Fix: after all cp -a lib copies in setupTar(), scan lib/ for absolute symlinks and rewrite them to relative (basename only). This is safe because all the referenced targets are copied into the same lib/ dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp -a preserves symlinks verbatim. On some cflinuxfs4 build hosts, /usr/lib/x86_64-linux-gnu/libgpg-error.so is an absolute symlink pointing to /lib/x86_64-linux-gnu/libgpg-error.so.0. libbuildpack rejects absolute symlinks during extraction as a security measure, causing PHP staging to fail with:
ERROR Could not install PHP: cannot link to an absolute path when extracting archives
Fix: after all cp -a lib copies in setupTar(), scan lib/ for absolute symlinks and rewrite them to relative (basename only). This is safe because all the referenced targets are copied into the same lib/ dir.
This is closely connected with PR cloudfoundry/php-buildpack#1250