Skip to content

Refactor subquery syntax in tests for clarity and consistency #8384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m3hm3t wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor subquery syntax in tests for clarity and consistency #8384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/test/regress/expected/subquery_in_where.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,23 +735,13 @@ WHERE
-- make the clause recurring
CREATE TABLE local_table(id int, value_1 int);
INSERT INTO local_table VALUES(1,1), (2,2);
SELECT
*
FROM
(SELECT
*
FROM
local_table) as sub_table
WHERE
id
IN
(SELECT
user_id
FROM
users_table);
SELECT s.*
FROM (SELECT * FROM local_table) AS s
WHERE s.id IN (SELECT u.user_id FROM users_table u)
ORDER BY s.id;
DEBUG: generating subplan XXX_1 for subquery SELECT id, value_1 FROM subquery_in_where.local_table
DEBUG: generating subplan XXX_2 for subquery SELECT user_id FROM public.users_table
DEBUG: Plan XXX query after replacing subqueries and CTEs: SELECT id, value_1 FROM (SELECT intermediate_result.id, intermediate_result.value_1 FROM read_intermediate_result('XXX_1'::text, 'binary'::citus_copy_format) intermediate_result(id integer, value_1 integer)) sub_table WHERE (id OPERATOR(pg_catalog.=) ANY (SELECT intermediate_result.user_id FROM read_intermediate_result('XXX_2'::text, 'binary'::citus_copy_format) intermediate_result(user_id integer)))
DEBUG: generating subplan XXX_2 for subquery SELECT user_id FROM public.users_table u
DEBUG: Plan XXX query after replacing subqueries and CTEs: SELECT id, value_1 FROM (SELECT intermediate_result.id, intermediate_result.value_1 FROM read_intermediate_result('XXX_1'::text, 'binary'::citus_copy_format) intermediate_result(id integer, value_1 integer)) s WHERE (id OPERATOR(pg_catalog.=) ANY (SELECT intermediate_result.user_id FROM read_intermediate_result('XXX_2'::text, 'binary'::citus_copy_format) intermediate_result(user_id integer))) ORDER BY id
id | value_1
---------------------------------------------------------------------
1 | 1
Expand Down
18 changes: 4 additions & 14 deletions src/test/regress/sql/subquery_in_where.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,20 +542,10 @@ WHERE
CREATE TABLE local_table(id int, value_1 int);
INSERT INTO local_table VALUES(1,1), (2,2);

SELECT
*
FROM
(SELECT
*
FROM
local_table) as sub_table
WHERE
id
IN
(SELECT
user_id
FROM
users_table);
SELECT s.*
FROM (SELECT * FROM local_table) AS s
WHERE s.id IN (SELECT u.user_id FROM users_table u)
ORDER BY s.id;

-- Use local table in WHERE clause
SELECT
Expand Down
Loading