CFE-3948: Changed remove to either remove all dependencies, else nothing#306
Merged
larsewi merged 2 commits intocfengine:masterfrom Mar 25, 2026
Merged
CFE-3948: Changed remove to either remove all dependencies, else nothing#306larsewi merged 2 commits intocfengine:masterfrom
larsewi merged 2 commits intocfengine:masterfrom
Conversation
SimonThalvorsen
force-pushed
the
CFE-3948
branch
2 times, most recently
from
bf42833 to
c040d61
Compare
larsewi
requested changes
Mar 18, 2026
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Looking good 🚀 Just a few nitpicks
Ticket: CFE-3948 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
CFE-3948
branch
from
c040d61 to
8ff3b80
Compare
Contributor
|
Maybe you could add a test? |
Ticket: CFE-3948 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
CFE-3948
branch
from
3ca5d87 to
7bc74e6
Compare
larsewi
reviewed
Mar 25, 2026
Comment on lines
+12
to
+13
| grep '"name": "example-module"' cfbs.json | ||
| grep '"name": "example-dependency"' cfbs.json |
Contributor
There was a problem hiding this comment.
In this case module and dependency does not make sense since their both modules and dependencies. Maybe module-a and module-b would make more sense?
larsewi
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CFE-3948